Skip to content

Commit

Permalink
edit comments in pmmlserver rock
Browse files Browse the repository at this point in the history
* fix a copy/paste error in the dockerfile reference
* edit comments slightly to increase commonality to other, similar rocks in this repo
  • Loading branch information
ca-scribner committed Feb 16, 2024
1 parent bf63a8c commit fc2f494
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pmmlserver/rockcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ parts:
pip install poetry==1.4.0
poetry config virtualenvs.create false
# Install the kserve and pmmlserver python packages and dependencies.
# Install the kserve package, this specific server package, and their dependencies.
#
# Poetry by default installs the root package as editable. This means the package
# is not put into dist-packages, and when we copy dist-packages to the final rock
# we will break the kserve and pmmlserver package installs.
# We work around that by installing kserve and pmmlserver from a dummy pyproject.toml
# we will break the kserve/this server's package installs.
# We work around that by installing kserve/this server from a dummy pyproject.toml
# that imports these packages as dependencies.
mkdir -p ./python_env_builddir
cp -rf $CRAFT_PROJECT_DIR/dummy_pyproject.toml ./python_env_builddir/pyproject.toml
Expand Down

0 comments on commit fc2f494

Please sign in to comment.