Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump sklearnserver rock to 0.11.2 #37

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

ca-scribner
Copy link
Contributor

@ca-scribner ca-scribner commented Feb 29, 2024

closes #35

Tester instructions

Launch the server with:

# download the model locally
gsutil cp -r gs://kfserving-examples/models/sklearn/1.0/model ./sample_model/

# mount the model into the container at runtime
docker run -p 8080:8080 -v $(pwd)/sample_model:/mnt/models sklearnserver:0.11.2 --model_name test_model --model_dir=/mnt/models --http_port=8080

Test the server with:

cat <<EOF >> iris-input-v2.json
{
  "inputs": [
    {
      "name": "input-0",
      "shape": [2, 4],
      "datatype": "FP32",
      "data": [
        [6.8, 2.8, 4.8, 1.4],
        [6.0, 3.4, 4.5, 1.6]
      ]
    }
  ]
}
EOF

curl -v \
  -H "Content-Type: application/json" \
  -d @./iris-input-v2.json \
  localhost:8080/v2/models/test_model/infer

Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ca-scribner, super tiny little comment, other than that LGTM.

sklearnserver/README.md Outdated Show resolved Hide resolved
sklearnserver/README.md Show resolved Hide resolved
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as here.

I think that this PR could be split in two just to unblock #35 and then we can move the discussion about the testing instructions elsewhere. wdyt?

@ca-scribner ca-scribner enabled auto-merge (squash) March 4, 2024 19:12
@ca-scribner ca-scribner merged commit e54c69e into main Mar 4, 2024
7 checks passed
@ca-scribner ca-scribner deleted the KF-5409-bump-sklearn-to-0.11.2 branch March 4, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a rock for kserve/sklearnserver:v0.11.2
2 participants