Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump paddleserver to 0.11.2, add testing instructions #40

Merged
merged 2 commits into from
Mar 4, 2024
Merged

bump paddleserver to 0.11.2, add testing instructions #40

merged 2 commits into from
Mar 4, 2024

Conversation

ca-scribner
Copy link
Contributor

closes #39

Testing instructions

See instructions in ./paddleserver/README.md

@DnPlas
Copy link
Contributor

DnPlas commented Mar 4, 2024

Same comment as here.

I think that this PR could be split in two just to unblock #39 and then we can move the discussion about the testing instructions elsewhere. wdyt?

DnPlas
DnPlas approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the change in #38, this LGTM. Thanks @ca-scribner !

@ca-scribner ca-scribner merged commit ee9909a into main Mar 4, 2024
7 checks passed
@ca-scribner ca-scribner deleted the KF-5411-bump-paddle-to-0.11.2 branch March 4, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnPlas DnPlas DnPlas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump the paddle rock to v0.11.2
2 participants
@ca-scribner @DnPlas