Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add controller rock (v0.11.2) #48

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

NohaIhab
Copy link
Contributor

closes #32

Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NohaIhab ! For some reason I am not able to build the rock to test it. Do you think there is something wrong with my setup? I get this:

ubuntu@charm-dev-jammy:~/kserve-rocks/controller$ rockcraft --version
rockcraft 1.2.2
ubuntu@charm-dev-jammy:~/kserve-rocks/controller$ rockcraft pack
ubuntu@charm-dev-jammy:~/kserve-rocks/controller$ ls
rockcraft.yaml  tests  tox.ini
ubuntu@charm-dev-jammy:~/kserve-rocks/controller$

@NohaIhab
Copy link
Contributor Author

@DnPlas that's odd, is there no output from the pack command? maybe try rockcraft pack -v for logs?

@NohaIhab
Copy link
Contributor Author

@DnPlas you can download the rock from the CI's artifacts in the meantime

Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NohaIhab I was able to build the image, it was an issue on my environment (I am using an arm machine).

On another topic, I saw at the beginning you defined an entrypoint, but that caused an issue, do you know why it was the case for you and not for other rocks? For instance, this one.

controller/rockcraft.yaml Outdated Show resolved Hide resolved
@NohaIhab
Copy link
Contributor Author

NohaIhab commented Mar 18, 2024

On another topic, I saw at the beginning you defined an entrypoint, but that caused an issue, do you know why it was the case for you and not for other rocks? For instance, this one.

@DnPlas
defining an entrypoint did not cause an issue, it's just unnecessary when we are not expecting additional arguments to be passed to the container when it's being started. See the rockcraft docs.

DnPlas
DnPlas previously approved these changes Mar 19, 2024
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NohaIhab !

Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NohaIhab :)

@NohaIhab NohaIhab merged commit 89c03a0 into main Mar 20, 2024
7 checks passed
@NohaIhab NohaIhab deleted the kf-5400-add-kserve-controller-rock branch March 20, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a rock for kserve/controller:v0.11.2
3 participants