Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace ROCKs with rocks #63

Merged
merged 3 commits into from
Jun 12, 2024
Merged

chore: replace ROCKs with rocks #63

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1056462
chore: replace ROCKs with rocks
DnPlas Jun 6, 2024
08c8843
skip: fix env var
DnPlas Jun 7, 2024
21c120f
skip: fix env var
DnPlas Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/on_pull_request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
jobs:

on-pull-request:
name: Get ROCKs modified and build-scan-test them
name: Get rocks modified and build-scan-test them
uses: canonical/charmed-kubeflow-workflows/.github/workflows/get-rocks-modified-and-build-scan-test-publish.yaml@main
permissions:
pull-requests: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on_push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:

on-push:
name: Get ROCKs modified and build-scan-test-publish them
name: Get rocks modified and build-scan-test-publish them
uses: canonical/charmed-kubeflow-workflows/.github/workflows/get-rocks-modified-and-build-scan-test-publish.yaml@main
permissions:
pull-requests: read
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ The KServe server images are a collection of different inference server runtimes

The Dockerfile for each of these images takes advantage of how each server is defined as a poetry package, using `poetry install` in the Dockerfile directly.

## Implementation details of the ROCKs in this repo
## Implementation details of the rocks in this repo

The ROCKs for the KServe servers require some atypical workarounds, mostly due to the upstream project using poetry to install its dependencies. These are documented here in detail, and briefly noted in the rockcraft.yaml files in this repository.
The rocks for the KServe servers require some atypical workarounds, mostly due to the upstream project using poetry to install its dependencies. These are documented here in detail, and briefly noted in the rockcraft.yaml files in this repository.

### Installing Python/pip via overlay-packages

Expand Down Expand Up @@ -70,4 +70,4 @@ The upstream install procedure results in `python` being executable, but our roc

## Integration testing the server images

For every inference server provided, upstream maintains an example usage in their [Model Serving Runtimes docs](https://kserve.github.io/website/master/modelserving/v1beta1/serving_runtime/). Each example includes a model for the given server, sample input, and an example `curl` call. These can be used for integration testing of the models without deploying KServe. See also the `README.md` files in the subdirs of this repo for some of these examples applied to our ROCKs.
For every inference server provided, upstream maintains an example usage in their [Model Serving Runtimes docs](https://kserve.github.io/website/master/modelserving/v1beta1/serving_runtime/). Each example includes a model for the given server, sample input, and an example `curl` call. These can be used for integration testing of the models without deploying KServe. See also the `README.md` files in the subdirs of this repo for some of these examples applied to our rocks.
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# kserve-rocks
ROCKs for Kserve
rocks for Kserve
6 changes: 3 additions & 3 deletions agent/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ commands =
bash -c 'NAME=$(yq eval .name rockcraft.yaml) && \
VERSION=$(yq eval .version rockcraft.yaml) && \
ARCH=$(yq eval ".platforms | keys | .[0]" rockcraft.yaml) && \
ROCK="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
rock="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
misohu marked this conversation as resolved.
Show resolved Hide resolved
DOCKER_IMAGE=$NAME:$VERSION && \
echo "Exporting $ROCK to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$ROCK docker-daemon:$DOCKER_IMAGE'
echo "Exporting $rock to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$rock docker-daemon:$DOCKER_IMAGE'

[testenv:sanity]
passenv = *
Expand Down
6 changes: 3 additions & 3 deletions controller/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ commands =
bash -c 'NAME=$(yq eval .name rockcraft.yaml) && \
VERSION=$(yq eval .version rockcraft.yaml) && \
ARCH=$(yq eval ".platforms | keys | .[0]" rockcraft.yaml) && \
ROCK="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
rock="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
DOCKER_IMAGE=$NAME:$VERSION && \
echo "Exporting $ROCK to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$ROCK docker-daemon:$DOCKER_IMAGE'
echo "Exporting $rock to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$rock docker-daemon:$DOCKER_IMAGE'

[testenv:sanity]
passenv = *
Expand Down
6 changes: 3 additions & 3 deletions lgbserver/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ commands =
bash -c 'NAME=$(yq eval .name rockcraft.yaml) && \
VERSION=$(yq eval .version rockcraft.yaml) && \
ARCH=$(yq eval ".platforms | keys | .[0]" rockcraft.yaml) && \
ROCK="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
rock="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
DOCKER_IMAGE=$NAME:$VERSION && \
echo "Exporting $ROCK to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$ROCK docker-daemon:$DOCKER_IMAGE'
echo "Exporting $rock to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$rock docker-daemon:$DOCKER_IMAGE'

[testenv:sanity]
passenv = *
Expand Down
6 changes: 3 additions & 3 deletions paddleserver/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ commands =
bash -c 'NAME=$(yq eval .name rockcraft.yaml) && \
VERSION=$(yq eval .version rockcraft.yaml) && \
ARCH=$(yq eval ".platforms | keys | .[0]" rockcraft.yaml) && \
ROCK="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
rock="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
DOCKER_IMAGE=$NAME:$VERSION && \
echo "Exporting $ROCK to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$ROCK docker-daemon:$DOCKER_IMAGE'
echo "Exporting $rock to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$rock docker-daemon:$DOCKER_IMAGE'

[testenv:sanity]
passenv = *
Expand Down
6 changes: 3 additions & 3 deletions pmmlserver/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ commands =
bash -c 'NAME=$(yq eval .name rockcraft.yaml) && \
VERSION=$(yq eval .version rockcraft.yaml) && \
ARCH=$(yq eval ".platforms | keys | .[0]" rockcraft.yaml) && \
ROCK="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
rock="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
DOCKER_IMAGE=$NAME:$VERSION && \
echo "Exporting $ROCK to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$ROCK docker-daemon:$DOCKER_IMAGE'
echo "Exporting $rock to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$rock docker-daemon:$DOCKER_IMAGE'

[testenv:sanity]
passenv = *
Expand Down
6 changes: 3 additions & 3 deletions sklearnserver/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ commands =
bash -c 'NAME=$(yq eval .name rockcraft.yaml) && \
VERSION=$(yq eval .version rockcraft.yaml) && \
ARCH=$(yq eval ".platforms | keys | .[0]" rockcraft.yaml) && \
ROCK="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
rock="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
DOCKER_IMAGE=$NAME:$VERSION && \
echo "Exporting $ROCK to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$ROCK docker-daemon:$DOCKER_IMAGE'
echo "Exporting $rock to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$rock docker-daemon:$DOCKER_IMAGE'

[testenv:sanity]
passenv = *
Expand Down
6 changes: 3 additions & 3 deletions storage-initializer/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ commands =
bash -c 'NAME=$(yq eval .name rockcraft.yaml) && \
VERSION=$(yq eval .version rockcraft.yaml) && \
ARCH=$(yq eval ".platforms | keys | .[0]" rockcraft.yaml) && \
ROCK="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
rock="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
DOCKER_IMAGE=$NAME:$VERSION && \
echo "Exporting $ROCK to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$ROCK docker-daemon:$DOCKER_IMAGE'
echo "Exporting $rock to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$rock docker-daemon:$DOCKER_IMAGE'

[testenv:sanity]
passenv = *
Expand Down
6 changes: 3 additions & 3 deletions xgbserver/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ commands =
bash -c 'NAME=$(yq eval .name rockcraft.yaml) && \
VERSION=$(yq eval .version rockcraft.yaml) && \
ARCH=$(yq eval ".platforms | keys | .[0]" rockcraft.yaml) && \
ROCK="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
rock="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
DOCKER_IMAGE=$NAME:$VERSION && \
echo "Exporting $ROCK to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$ROCK docker-daemon:$DOCKER_IMAGE'
echo "Exporting $rock to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$rock docker-daemon:$DOCKER_IMAGE'

[testenv:sanity]
passenv = *
Expand Down
Loading