Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging relation to tensorboards-controller #118

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented Jul 9, 2024

Use LogForwarder from loki_push_api library to forwards all logs from workload container to Loki. This requires to use ops 2.9 or newer, so it was needed to be updated.

fixes: #110

How I tested it:

# deployed the cos following https://charmhub.io/topics/canonical-observability-stack/tutorials/install-microk8s
$ tox -e integration -- --keep-models
$ juju switch test-charm-98bl
$ charmcraft pack  # since there is test removing charm
Created 'tensorboard-controller_ubuntu-20.04-amd64.charm'.

Charms packed:

    tensorboard-controller_ubuntu-20.04-amd64.charm 
$ juju deploy ./tensorboard-controller_ubuntu-20.04-amd64.charm --resource tensorboard-controller-image=kubeflownotebookswg/tensorboard-controller:v1.9.0-rc.0
Located local charm "tensorboard-controller", revision 0
Deploying "tensorboard-controller" from local charm "tensorboard-controller", revision 0 on [email protected]/stable
$ juju consume u1-k8s:cos.loki-logging 
Added u1-k8s:admin/cos.loki-logging as loki-logging
$ juju integrate grafana-agent-k8s loki-logging
$ juju integrate grafana-agent-k8s tensorboard-controller:logging
$ juju integrate tensorboard-controller:gateway-info istio-pilot

And after checking the Grafana, I was able to see all logs.
Screenshot from 2024-07-09 13-19-00

Use LogForwarder from loki_push_api library to forwards all logs from
workload container to Loki. This requires to use ops 2.9 or newer, so it
was needed to be updated.

fixes: #110
@rgildein rgildein added the enhancement New feature or request label Jul 9, 2024
@rgildein rgildein self-assigned this Jul 9, 2024
@rgildein rgildein requested a review from a team as a code owner July 9, 2024 11:21
@rgildein rgildein merged commit 5a500bc into main Jul 11, 2024
14 checks passed
@rgildein rgildein deleted the feat/KF-5789/log-forwarding branch July 11, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logging relation to tensorboard-controller charm
2 participants