Split bases to fix install errors #115
Merged
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelallan72
requested review from
Pjack,
aieri,
jneo8,
gabrielcocenza,
rgildein and
chanchiwai-ray
`charm` was pinned to 2.x, which uses a bundled version of python[0] (I think python3.6). See https://forum.snapcraft.io/t/2-x-and-3-x-tracks-for-the-charm-snap/31937 . This means that the requirements resolved from wheelhouse.txt at build time are not necessarily the same requirements as would be installed at deploy time, because the python version may be different. So this caused missing python package dependencies during install on focal and jammy. According to juju/charm-tools#640 , this can be fixed by switching to `charm` 3.x, and separating the bases so the charm for each base is built on that base. This ensures that the same version of python is used at build time as at runtime. Fixes: #112 Fixes: #114
chanchiwai-ray
approved these changes
Jul 25, 2024
|
Merged without workflow passing, because the workflow is known to fail because there are no tests. |
samuelallan72
added a commit
that referenced
this pull request
Jul 25, 2024
libpython3-dev is required to build cython. See canonical/layer-basic#214 This problem is only evident now since we switched to charm 3.x in charmcraft builds in #115 ref. https://review.opendev.org/c/openstack/charm-keystone-ldap/+/880084
samuelallan72
added a commit
that referenced
this pull request
Jul 26, 2024
libpython3-dev is required to build cython. See canonical/layer-basic#214 This problem is only evident now since we switched to charm 3.x in charmcraft builds in #115 ref. https://review.opendev.org/c/openstack/charm-keystone-ldap/+/880084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charmwas pinned to 2.x, which uses a bundled version of python (I think python3.6).See https://forum.snapcraft.io/t/2-x-and-3-x-tracks-for-the-charm-snap/31937 . This means that the requirements resolved from wheelhouse.txt at build time are not necessarily the same requirements as would be installed at deploy time,
because the python version may be different.
So this caused missing python package dependencies during install on focal and jammy.
According to juju/charm-tools#640 , this can be fixed by switching to
charm3.x,and separating the bases
so the charm for each base is built on that base.
This ensures that the same version of python is used at build time as at runtime.
Fixes: #112
Fixes: #114