tests/cgroup: on cgroup1 systems, the swap limit is set to limits.memory * 2 #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
force-pushed
the
cgroup1-memlimit
branch
2 times, most recently
from
518a70b
to
0116c48
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Simon Deziel <[email protected]>
simondeziel
force-pushed
the
cgroup1-memlimit
branch
from
0116c48
to
041282d
Compare
|
As mentioned in chat, I think that trying to make all tests work on 20.04 with modern LXD is going to be a time sync. Expanding the exclusion matrix to limit what is tested on 20.04 is probably the way to go (rather than merging this PR). Even with the swaptotal issue fixed, the |
|
Lets wait until @mihalicyn has a look, if this is expected behaviour then we can indeed test for it. |
|
@mihalicyn @simondeziel do we still need this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.