Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/storage-vm: Add test for live resizing of VM disks with zfs or lvm pool driver #310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kadinsayani
Copy link
Contributor

@kadinsayani kadinsayani commented Oct 8, 2024

This PR adds tests for canonical/lxd#14211. The test depends on presence of the feature which is indicated by the api extension vm_storage_disk_live_resize.

tests/storage-vm Fixed Show fixed Hide fixed
tests/storage-vm Fixed Show fixed Hide fixed
tests/storage-vm Fixed Show fixed Hide fixed
tests/storage-vm Fixed Show fixed Hide fixed
tests/storage-vm Fixed Show fixed Hide fixed
tests/storage-vm Outdated Show resolved Hide resolved
tests/storage-vm Outdated Show resolved Hide resolved
tests/storage-vm Outdated Show resolved Hide resolved
@kadinsayani kadinsayani force-pushed the vm-disk-resize-tests branch 4 times, most recently from db901b4 to aa33380 Compare October 9, 2024 16:56
tests/storage-vm Outdated Show resolved Hide resolved
simondeziel
simondeziel previously approved these changes Oct 9, 2024
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all storage drivers are to grow support for live resize then the extension name will change before landing in LXD.

As for the testing logic, it looks good to me even if I've not seen it in action for the LIVE_GROWING_SUPPORTED=1 case.

Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on "paper". I'm assuming you've run this locally with a side loaded LXD binary that has the proper API extensions to exercise the live resize :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants