Network: Return ACL logs from syslogs when the OVN controller is deployed in MicroOVN #14327

gabrielmougard · 2024-10-23T10:05:21Z

We need to remember to enable the log tests for microovn on canonical/lxd-ci#368 when this is merged

gabrielmougard · 2024-10-25T18:29:35Z

@tomponline this should be working. Regarding the documentation, as we discussed earlier, we probably need to add a note in the doc section Set up a LXD cluster on OVN to tell that a northbound_db_connection can also be added as a unix socket pointing toward an existing MicroOVN installation (unix:/var/snap/microovn/common/run/ovn/ovnnd_db.sock). However, as discovered here https://chat.canonical.com/canonical/pl/7fdhjesei3n9tcz1tkwbastozr, this seems to work only for a single node MicroOVN.. Do we really want to document that if it is not working for a multi node MicroOVN deployment?

gabrielmougard · 2024-10-25T19:01:15Z

Here is the lxd-ci PR: canonical/lxd-ci#330

gabrielmougard · 2024-10-30T08:25:31Z

@tomponline the lxd-ci PR is ready at: https://github.com/canonical/lxd-ci/actions/runs/11599574607/job/32305555034?pr=330

Actually this lxd-ci PR completely enables MicroOVN as a 'backend' for the OVN tests so no need to add new acl show-logs tests.

github-actions · 2024-10-31T11:00:30Z

Heads up @mionaalex - the "Documentation" label was applied to this issue.

doc/howto/network_ovn_setup.md

lxd/network/acl/acl_ovn.go

lxd/network/acl/driver_common.go

canonical/lxd#14327 is needed to get access to MicroOVN logs. Signed-off-by: Simon Deziel <[email protected]>

lxd/network/acl/driver_common.go

tomponline

Some minor refactoring to do please

gabrielmougard · 2025-01-06T12:06:52Z

@tomponline updated (with one question ;) ) ... and happy new year !

lxd/network/acl/acl_utils.go

lxd/network/acl/acl_ovn.go

tomponline

Some minor changes to make and then we are good to go, thanks!

Signed-off-by: Gabriel Mougard <[email protected]>

…n external timestamp When reading a log file, the logtime (timestamp of the log entry) is part of the entry but when we read a syslog, the logtime is not contained in the log entry fields and need to be parsed and converted. We added two local functions to cope with these two usages: * 'parseLogTimeFromFields' * 'parseLogTimeFromTimestamp' (used when the OVN deployment is part of MicroOVN and we need to read the syslog) Signed-off-by: Gabriel Mougard <[email protected]>

In the case of an OVN controller being deployed as part of a MicroOVN deployment, the OVN controller logs are stored in MicroOVN's snap syslog. The LXD snap should have root access, which means that it should be authorized (this is being tested) to read the OVN controller logs. Signed-off-by: Gabriel Mougard <[email protected]>

Passing the request ctx to the GetLog function allows to stop the syslog stream (in case of OVN being deployed with MicroOVN) in case of request interruption Signed-off-by: Gabriel Mougard <[email protected]>

…ion to LXD When a user decides to deploy OVN through a MicroOVN deployment, it is not clearly explained how to connect LXD and MicroOVN. The only missing info was how to correctly setup the northbound connection: `lxc config set network.ovn.northbound_connection <ovn-northd-nb-db>` With `<ovn-northd-nb-db>` that MUST use the `ssl:<microovn_node_ip>:6641`. Passing a UNIX socket targeting `ovnnb_db.sock` inside the MicroOVN snap will produce certificate errors so we MUSN'T use the UNIX notation. Signed-off-by: Gabriel Mougard <[email protected]>

tomponline

LGTM thanks!

Just need to put up a PR with the snap ovn test now, based on the changes in canonical/lxd-ci#368 from @simondeziel

gabrielmougard · 2025-01-07T13:08:16Z

LGTM thanks!

Just need to put up a PR with the snap ovn test now, based on the changes in canonical/lxd-ci#368 from @simondeziel

@tomponline actually it's unclear. By the 'snap ovn test', do you mean connecting an OVN controller inside the OVN chassis snap (https://snapcraft.io/ovn-chassis) to the LXD snap and run the lxd-ci 'ovn' tests ?

tomponline · 2025-01-07T13:51:04Z

LGTM thanks!
Just need to put up a PR with the snap ovn test now, based on the changes in canonical/lxd-ci#368 from @simondeziel

@tomponline actually it's unclear. By the 'snap ovn test', do you mean connecting an OVN controller inside the OVN chassis snap (https://snapcraft.io/ovn-chassis) to the LXD snap and run the lxd-ci 'ovn' tests ?

yes, testing that this PR is working with microovn

tomponline · 2025-01-07T14:02:02Z

LGTM thanks!
Just need to put up a PR with the snap ovn test now, based on the changes in canonical/lxd-ci#368 from @simondeziel

@tomponline actually it's unclear. By the 'snap ovn test', do you mean connecting an OVN controller inside the OVN chassis snap (https://snapcraft.io/ovn-chassis) to the LXD snap and run the lxd-ci 'ovn' tests ?

yes, testing that this PR is working with microovn

How is it passing if this isnt merged yet?

simondeziel · 2025-01-07T14:24:06Z

Re the lxd-ci bit, it's only going to look at the ACL logs when OVN is a deb:

    if [ "${OVN_SOURCE:-latest/edge}" = "deb" ]; then

tomponline · 2025-01-07T14:38:32Z

Re the lxd-ci bit, it's only going to look at the ACL logs when OVN is a deb:
    if [ "${OVN_SOURCE:-latest/edge}" = "deb" ]; then

thanks, so we'll need that relaxed then @gabrielmougard

gabrielmougard force-pushed the fix/microovn-logs branch from ddd4d19 to af03834 Compare October 23, 2024 10:11

gabrielmougard changed the title ~~lxd/network/acl: return ACL logs when the OVN controller is deployed in MicroOVN~~ lxd/network/acl: return ACL logs from syslogs when the OVN controller is deployed in MicroOVN Oct 23, 2024

gabrielmougard mentioned this pull request Oct 23, 2024

snapcraft: Add libsystemd-dev dependency for LXD canonical/lxd-pkg-snap#581

Closed

gabrielmougard force-pushed the fix/microovn-logs branch 5 times, most recently from d4828be to 316aeed Compare October 25, 2024 18:24

gabrielmougard marked this pull request as ready for review October 25, 2024 18:25

gabrielmougard mentioned this pull request Oct 25, 2024

tests/network-ovn: Add MicroOVN as a backend for network-ovn test suite canonical/lxd-ci#330

Closed

gabrielmougard self-assigned this Oct 28, 2024

gabrielmougard force-pushed the fix/microovn-logs branch 2 times, most recently from ab7cce7 to 1794edb Compare October 30, 2024 08:18

gabrielmougard force-pushed the fix/microovn-logs branch 2 times, most recently from bc42c46 to fea89eb Compare October 31, 2024 11:00

github-actions bot added the Documentation Documentation needs updating label Oct 31, 2024

minaelee reviewed Nov 3, 2024

View reviewed changes

doc/howto/network_ovn_setup.md Outdated Show resolved Hide resolved

gabrielmougard force-pushed the fix/microovn-logs branch from fea89eb to 0106b44 Compare November 4, 2024 13:21

gabrielmougard requested a review from tomponline November 4, 2024 13:21

gabrielmougard force-pushed the fix/microovn-logs branch from 0106b44 to c2de174 Compare November 4, 2024 15:49

simondeziel reviewed Nov 4, 2024

View reviewed changes

lxd/network/acl/acl_ovn.go Outdated Show resolved Hide resolved

lxd/network/acl/driver_common.go Outdated Show resolved Hide resolved

lxd/network/acl/driver_common.go Outdated Show resolved Hide resolved

gabrielmougard force-pushed the fix/microovn-logs branch from c2de174 to c70a986 Compare November 5, 2024 09:40

gabrielmougard requested review from simondeziel and minaelee November 5, 2024 09:41

tomponline changed the title ~~lxd/network/acl: return ACL logs from syslogs when the OVN controller is deployed in MicroOVN~~ Network: Return ACL logs from syslogs when the OVN controller is deployed in MicroOVN Nov 5, 2024

minaelee previously approved these changes Nov 5, 2024

View reviewed changes

simondeziel added a commit to simondeziel/lxd-ci that referenced this pull request Dec 12, 2024

tests/network-ovn: ignore empty ACL logs if not using deb

99c626f

canonical/lxd#14327 is needed to get access to MicroOVN logs. Signed-off-by: Simon Deziel <[email protected]>

simondeziel added a commit to simondeziel/lxd-ci that referenced this pull request Dec 12, 2024

tests/network-ovn: ignore empty ACL logs if not using deb

1625850

canonical/lxd#14327 is needed to get access to MicroOVN logs. Signed-off-by: Simon Deziel <[email protected]>

simondeziel added a commit to simondeziel/lxd-ci that referenced this pull request Dec 12, 2024

tests/network-ovn: ignore empty ACL logs if not using deb

5b89e3f

canonical/lxd#14327 is needed to get access to MicroOVN logs. Signed-off-by: Simon Deziel <[email protected]>

tomponline reviewed Dec 13, 2024

View reviewed changes

lxd/network/acl/driver_common.go Outdated Show resolved Hide resolved

tomponline reviewed Dec 13, 2024

View reviewed changes

lxd/network/acl/driver_common.go Outdated Show resolved Hide resolved

tomponline reviewed Dec 13, 2024

View reviewed changes

lxd/network/acl/driver_common.go Outdated Show resolved Hide resolved

tomponline requested changes Dec 13, 2024

View reviewed changes

gabrielmougard force-pushed the fix/microovn-logs branch from 29c825d to f7396fd Compare January 6, 2025 10:23