Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass request to Render backport (stable-5.21) #14409

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

roosterfish
Copy link
Contributor

This backports the necessary commits into stable-5.21 that allow passing the request into the response Render func.

See canonical/microcluster#277 (comment) for the origin of this request.

Signed-off-by: hamistao <[email protected]>
(cherry picked from commit ba31a90)
Signed-off-by: hamistao <[email protected]>
(cherry picked from commit 9143502)
Signed-off-by: hamistao <[email protected]>
(cherry picked from commit 815cdb2)
@roosterfish roosterfish changed the title Request in Render backport (stable-5.21) Pass request to Render backport (stable-5.21) Nov 6, 2024
Signed-off-by: hamistao <[email protected]>
(cherry picked from commit b3230b4)
Signed-off-by: hamistao <[email protected]>
(cherry picked from commit f6e4f99)
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta!

@tomponline tomponline merged commit f0be5c8 into canonical:stable-5.21 Nov 6, 2024
23 of 24 checks passed
tomponline added a commit to canonical/microcluster that referenced this pull request Nov 6, 2024
As part of #277 the
changes to `Render` (originally introduced in
#252) got reverted to
allow tracking `[email protected]` which didn't contain the necessary
changes to `Render`.

After backporting the changes to LXD's `stable-5.21` with
canonical/lxd#14409, we can restore the original
changes using the latest version of LXD in `stable-5.21`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants