-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lxd/device: unix-hotplug
ownership fix
#14417
base: main
Are you sure you want to change the base?
lxd/device: unix-hotplug
ownership fix
#14417
Conversation
a0b63fd
to
8fed8a3
Compare
unix-hotplug
ownership fixunix-hotplug
ownership fix
8fed8a3
to
0d5c055
Compare
@kadinsayani please can you update the PR description to explain the change of behaviour in this PR and what, if any, will change for existing users? |
Sure thing! |
0d5c055
to
2600eb1
Compare
…g copy logic Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
db02e22
to
4c9ee63
Compare
Heads up @mionaalex - the "Documentation" label was applied to this issue. |
a25f26f
to
81478b0
Compare
13be986
to
ebc953a
Compare
@tomponline, do we need an API extension for the new setting even if we're not adding tests? |
Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
ebc953a
to
c78aeda
Compare
Fixes the second bug raised in #14266.
This PR adds a setting,
ownership.inherit
forunix-hotplug
devices and a functionunixDeviceOwnership()
which returns device ownership.New behaviour:
ownership.inherit
isfalse
;ownership.inherit
is set totrue
, the device ownership is inherited from the host;ownership.inherit
cannot be set totrue
whengid
oruid
are set.Existing behaviour (unchanged):
gid
anduid
are set, they are used for device ownership;gid
anduid
are not present in the config, root (0) ownership is used.