Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve USB ID type handling #14453

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Improve USB ID type handling #14453

merged 3 commits into from
Nov 13, 2024

Conversation

simondeziel
Copy link
Member

No description provided.

kadinsayani
kadinsayani reviewed Nov 12, 2024
View reviewed changes
shared/usbid/parse.go Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 12, 2024
View reviewed changes
shared/usbid/parse.go Fixed Show fixed Hide fixed
@simondeziel simondeziel marked this pull request as ready for review November 12, 2024 23:20
@simondeziel
Copy link
Member Author

This is trying to address https://github.com/canonical/lxd/security/code-scanning?query=is%3Aopen+branch%3Amain+rule%3Ago%2Fincorrect-integer-conversion+path%3Ashared%2Fusbid

@tomponline tomponline merged commit 6dbc740 into canonical:main Nov 13, 2024
27 checks passed
@simondeziel simondeziel deleted the int-size branch November 13, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadinsayani kadinsayani kadinsayani left review comments

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simondeziel @tomponline @kadinsayani