Storage: Add Pure Storage storage driver #14599
Draft
+4,337
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return err | ||
| } | ||
|
|
||
| err = os.Remove(mountPath) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
There was a problem hiding this comment.
I believe @simondeziel is planning to address this issue more generally higher up the call stack, so wont block this PR.
MusicDin
force-pushed
the
feat/pure-driver
branch
2 times, most recently
from
c53014e to
69f6cae
Compare
simondeziel
reviewed
Dec 6, 2024
doc/howto/storage_pools.md
Outdated
|
|
||
| Create a storage pool named `pool1` that uses NVMe/TCP by default: | ||
|
|
||
| lxc storage create pool1 pure pure.gateway=https://<purestorage-address> pure.api.token=<purestorage-api-token> pure.array.address=<nvme-ip> |
There was a problem hiding this comment.
That gateway HTTPS verification presumably relies on the OS provided trust store so it would work if it's an "official TLS" cert like one signed by Let's Encrypt.
I must admit not knowing how to provide a different trusted CA if one doesn't have an official cert.
MusicDin
force-pushed
the
feat/pure-driver
branch
from
69f6cae to
231d0f0
Compare
minaelee
reviewed
Dec 6, 2024
MusicDin
force-pushed
the
feat/pure-driver
branch
from
231d0f0 to
276bb1b
Compare
|
@minaelee Thanks for the comments. I've addressed all of them, but will ask you for another review just before we merge the PR, as there may still be some changes to the docs. Thanks again :) |
simondeziel
reviewed
Dec 9, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
tomponline
reviewed
Dec 10, 2024
Signed-off-by: Din Music <[email protected]>
…ce information Signed-off-by: Din Music <[email protected]>
…volumes Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
…zed images Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Pure Storage does not allow mounting snapshots directly, therefore we have to create a new volume from it before mounting it. Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
…ge pool is created Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
… token are set Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Correctly initialize Pure Storage pool. Signed-off-by: Din Music <[email protected]>
…lable storage drivers Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Currently, Pure Storage driver does not support recovery. Mainly bacuse the storage volume names are encoded, which would result in indistinguishable storage volume names after the recovery. Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
… drivers Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
feat/pure-driver
branch
from
c4de43a to
1a8a42a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
purestorage driver for Pure Storage remote storage.Driver supports communication over either iSCSI or NVMe/TCP.
iscsiadmto the LXD host: commands/daemon: Redirect iscsiadm to the host lxd-pkg-snap#646