Storage: Fix PowerFlex NVMe subsystem ENOENT #14708
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julian Pelizäus <[email protected]>
MusicDin
reviewed
Dec 20, 2024
|
|
||
| if stderr != "" { | ||
| return nil, fmt.Errorf("Failed connecting to PowerFlex NVMe/TCP subsystem: %s", stderr) | ||
| revert.Add(func() { _ = d.disconnectNVMeSubsys() }) |
There was a problem hiding this comment.
While this reverted is currently never executed, I think we should not even try to revert connection if it fails. Instead we should rely on the caller to revert volume mapping because if there are other volumes connected it would simply disconnect them. On the other side, the unmap will take care that it gets disconnected only if there is no other volumes connected.
|
@roosterfish @MusicDin can we separate the pure driver from the changes in #14700 so we can include this in LXD (including the fix from this PR) in LXD 5.21.3 before pure lands? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case no NVMe subsystem is connected, it appears that the
/sys/devices/virtual/nvme-subsystemmight not exist.This can be due to a newer kernel version (saw this happen on
5.15.0-130-generic).The fix is to check for ENOENT and only try to parse the subsystems in case the directory exists.
Looks this is already fixed in https://github.com/canonical/lxd/pull/14700/files#diff-715b401f96a8a50ff84a548172cb47b0c2ded1c49ce881ee56a2377319927a97R69.