CLI: lxc network forward completion improvements
#14713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cmpNetworkLoadBalancers` should return load balancer addresses, not network forward addresses. Signed-off-by: Kadin Sayani <[email protected]>
simondeziel
reviewed
Jan 6, 2025
kadinsayani
force-pushed
the
14697-load-balancer-port-address-completion
branch
from
dd2d915 to
41fcb6e
Compare
simondeziel
reviewed
Jan 6, 2025
…sses Closes canonical#14697. This commit adds `cmpNetworkForwardPortTargetAddresses` to provide target address completions for `lxc network forward port add`. Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
kadinsayani
force-pushed
the
14697-load-balancer-port-address-completion
branch
from
41fcb6e to
63ae032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14697.
Summary of changes:
cmpNetworkLoadBalancers.cmpNetworkLoadBalancersshould return load balancer addresses, notnetwork forward addresses.
cmpNetworkForwardPortTargetAddressesto provide target address completions forlxc network forward port add.lxc network forwardcreate.