Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes #14714

Merged
merged 49 commits into from
Jan 9, 2025
Merged

Misc fixes #14714

merged 49 commits into from
Jan 9, 2025

Conversation

simondeziel
Copy link
Member

No description provided.

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Dec 20, 2024
@simondeziel simondeziel marked this pull request as ready for review December 22, 2024 16:19
tomponline
tomponline reviewed Dec 22, 2024
View reviewed changes
lxd/db/instances.go Outdated Show resolved Hide resolved
tomponline
tomponline reviewed Jan 7, 2025
View reviewed changes
lxd/db/instances.go Outdated Show resolved Hide resolved
tomponline
tomponline reviewed Jan 7, 2025
View reviewed changes
lxc/completion.go Outdated Show resolved Hide resolved
tomponline
tomponline reviewed Jan 7, 2025
View reviewed changes
lxd/instances_post.go Outdated Show resolved Hide resolved
tomponline
tomponline requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor changes.

@simondeziel
shared/util: fix copy-n-pasto
e3d32aa 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
doc/instance-exec: fix typo
a73ee0b 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/instance_logs: fix typo in swagger comment
8f56717 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/project/project: simplify string concatenation operations
4b9409c 
`fmt.Sprintf` being much slower it should be kept for when it is really needed.
It's slowness comes from using reflection under the hood making it the slowest
of the `fmt.Sprint*` functions.

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
shared/util: simplify string concatenation operations
5ea6c15 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/instance_logs: simplify string concatenation operations
4d84a2a 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/storage/drivers/lvm: avoid format specifiers in errors
cdba0f5 
LVM commands often use `100%FREE` or `100%ORIGIN` which can be interpreted as
format specifiers when passed to `fmt.Sprintf` for example.

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
shared/util_test: simplify if/else (revive)
3e81bb1 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/db/instances: simplify GetNextInstanceSnapshotIndex()
509dcc0 
Avoid accessing slice out of bound if no `%d` is present in the pattern.
The snapshot pattern doesn't need `%d` to be escaped now that `Sprintf` isn't
used.

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/db/instances: replace strings.Contains+strings.SplitN by strings.Cut
f0478c0 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxc/completion: replace strings.Contains+strings.Split by strings.Cut
751c548 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/db/storage_volume_snapshots: use strings.Cut to avoid out of boun…
12bcb1d 
…d access

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/db/storage_volumes: use strings.Cut() in RenameStoragePoolVolume()
e5ce5c3 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/db/storage_volumes: simplify GetNextStorageVolumeSnapshotIndex()
08ed3e1 
Avoid accessing slice out of bound if no `%d` is present in the pattern.
The snapshot pattern doesn't need `%d` to be escaped now that `Sprintf` isn't
used.

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/instance/instancetype/instance: simplify ValidName()
188c896 
The validate.IsHostname() already rejects `/` so there is no need to explicitly
check for `/` in the instance name.

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/db/instances: use strconv.Itoa() where appropriate
f7a6295 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/images: use %w format specifying in fmt.Errorf()
5529d63 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/images: simplify command line arg preparation
6d878df 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/images: don't report progress with tar2sqfs
53ed3e5 
This progress indicator was only shown in case of error.

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/instances_post: petname.Generate() gives all lower case already
a8cffa0 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/instances_post: prefer Sprint to Sprintf
92fdf63 
Signed-off-by: Simon Deziel <[email protected]>

lxd/instances_post: prefer strconv.Itoa to Sprintf

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/instances_post: use simpler string concatenation
cb2a9eb 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxc/file: pre-allocate files
7935783 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxc/file: don't try to close os.Stdin
8f27c2e 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/linux/memfd: ignore unix.Close error
4512c0e 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
test/mini-oidc: remove redundant return
aac1ffb 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
test/mini-oidc: add missing trailing dots
6b56e85 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
test/mini-oidc: sort imports
c40ec6e 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/cluster/notify: pre-allocate peers
9796ed7 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/storage/drivers/lvm_utils: use named return values
0166651 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/storage/drivers/lvm_utils: simplify if/else with early return
4c52761 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
test/mini-oidc/storage/oidc: use proper casing
3f504c5 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
test/mini-oidc/storage/oidc: define prompts with 0 length
848b729 
This slice is only `append()`'ed to.

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
test/mini-oidc: add comments to exported functions
ae9f297 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
test/mini-oidc: silence some lint problems
f1cc859 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
test/mini-oidc: drop unused param
12efa42 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/init: omit unneeded nil checks
181bc19 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/resources/network: simplify if/else with early return
f408dfb 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/resources/utils: simplify if/else with early return
b24a12f 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
shared/api/status_code: pre-allocate statusStrings
f018dea 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
shared/api/resource: fix typo in comment
d1c9012 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
doc/rest-api: Refresh swagger YAML
046e100 
Signed-off-by: Simon Deziel <[email protected]>
@tomponline tomponline merged commit 0116fcc into canonical:main Jan 9, 2025
28 checks passed
@simondeziel simondeziel deleted the misc branch January 9, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minaelee minaelee minaelee left review comments

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simondeziel @tomponline @minaelee