Skip to content

Commit

Permalink
Add static target
Browse files Browse the repository at this point in the history
  • Loading branch information
arturo-seijas committed Aug 25, 2023
1 parent e1014ad commit d497670
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# See LICENSE file for licensing details.

import logging
import subprocess
import subprocess # nosec
from ipaddress import ip_network
from urllib.parse import urlparse
from zlib import crc32
Expand All @@ -27,7 +27,7 @@
# Default port, enforced via envConfig to prevent operator error
METRICS_PORT = 8067
DATABASE_NAME = "mattermost"
LICENSE_SECRET_KEY_NAME = "licence"
LICENSE_SECRET_KEY_NAME = "licence" # nosec
REQUIRED_S3_SETTINGS = ["s3_bucket", "s3_region", "s3_access_key_id", "s3_secret_access_key"]
REQUIRED_SETTINGS = ["mattermost_image_path"]
REQUIRED_SSO_SETTINGS = ["licence", "site_url"]
Expand Down Expand Up @@ -111,7 +111,7 @@ def _on_grant_admin_role_action(self, event):
"""Handle the grant-admin-role action."""
user = event.params["user"]
cmd = ["/mattermost/bin/mattermost", "roles", "system_admin", user]
granted = subprocess.run(cmd, capture_output=True)
granted = subprocess.run(cmd, capture_output=True) # nosec
if granted.returncode != 0:
event.fail(
"Failed to run '{}'. Output was:\n{}".format(
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ async def app(
{
"MM_FILESETTINGS_AMAZONS3SSL": "false",
"MM_SERVICESETTINGS_ENABLELOCALMODE": "true",
"MM_SERVICESETTINGS_LOCALMODESOCKETLOCATION": "/tmp/mattermost.socket",
"MM_SERVICESETTINGS_LOCALMODESOCKETLOCATION": "/tmp/mattermost.socket", # nosec
}
),
}
Expand Down

0 comments on commit d497670

Please sign in to comment.