Adapt integration tests to reuse the packed charm #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkandersson
previously approved these changes
Jul 24, 2023
weiiwang01
previously approved these changes
Aug 24, 2023
* Fix image build * Fix image build * Ignore CVE
arturo-seijas
dismissed stale reviews from weiiwang01 and jdkandersson
via
37c5118
weiiwang01
previously approved these changes
Aug 24, 2023
arturo-seijas
dismissed stale reviews from yanksyoon and weiiwang01
via
5381de8
weiiwang01
previously approved these changes
Aug 24, 2023
yanksyoon
previously approved these changes
Aug 24, 2023
arturo-seijas
dismissed stale reviews from yanksyoon and weiiwang01
via
8cf3ae9
yanksyoon
previously approved these changes
Aug 25, 2023
weiiwang01
previously approved these changes
Aug 25, 2023
arturo-seijas
dismissed stale reviews from weiiwang01 and yanksyoon
via
42aef48
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 41 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 12 | 10 | 19 | 0 |
Click to see the invalid file list
- COPYRIGHT
- actions.yaml
- charmcraft.yaml
- config.yaml
- files/canonical_flavour/https-proxy-agent.patch
- files/canonical_flavour/themes.patch
- mattermost.Dockerfile
- metadata.yaml
- tests/conftest.py
- tests/integration/localstack-installation.sh
There was a problem hiding this comment.
license-eye has totally checked 42 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 19 | 2 | 21 | 0 |
Click to see the invalid file list
- COPYRIGHT
- tox.ini
There was a problem hiding this comment.
license-eye has totally checked 42 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 19 | 2 | 21 | 0 |
Click to see the invalid file list
- COPYRIGHT
- tox.ini
weiiwang01
previously approved these changes
Aug 25, 2023
arturo-seijas
dismissed stale reviews from yanksyoon, merkata, and weiiwang01
via
f2c10d6
merkata
previously approved these changes
Aug 25, 2023
merkata
approved these changes
Aug 25, 2023
nrobinaubertin
approved these changes
Aug 25, 2023
weiiwang01
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the integration tests to reuse the exisintg charm artifact as per canonical/operator-workflows#162 and fix the docker build: