api: Less explicit, but with string checks

Signed-off-by: Max Asnaashari <[email protected]>

api/services_tokens.go

@@ -41,6 +41,10 @@ func IsSafeVarPath(path string) error {
 		varDir = "/var/lib/lxd"
 	}
 
+	if strings.Contains(path, "/") || strings.Contains(path, "\\") || strings.Contains(path, "..") {
+		return fmt.Errorf("test err")
+	}
+
 	if !strings.HasPrefix(absPath, varDir) {
 		return errors.New("Absolute path is outside the default LXD path")
 	}
@@ -70,15 +74,6 @@ func serviceTokensPost(s *state.State, r *http.Request) response.Response {
 		return response.SmartError(err)
 	}
 
-	if strings.Contains(req.JoinerName, "/") || strings.Contains(req.JoinerName, "\\") || strings.Contains(req.JoinerName, "..") {
-		return response.SmartError(err)
-	}
-
-	_, err = filepath.Abs(req.JoinerName)
-	if err != nil {
-		return response.SmartError(err)
-	}
-
 	_ = os.MkdirAll(req.JoinerName, 0700)
 
 	sh, err := service.NewHandler(s.Name(), req.ClusterAddress, s.OS.StateDir, false, false, types.ServiceType(serviceType))