Allow skipping systems for ceph #125
Conversation
Signed-off-by: Max Asnaashari <[email protected]>
Since some systems might not be able to join ceph or ovn, this adds a confirmation (defaults to yes) to ensure the user is aware that some machines might be missing from disk or network interface selection, and thus ceph or ovn, respectively. Signed-off-by: Max Asnaashari <[email protected]>
| @@ -520,6 +523,17 @@ func askNetwork(sh *service.ServiceHandler, peers map[string]mdns.ServerInfo, lx | |||
| return nil, nil, nil | |||
| } | |||
|
|
|||
| if len(peers) != len(networks) { | |||
| wantsSkip, err := cli.AskBool("Some systems are ineligible for distributed networking. Continue anyway? (yes/no) [default=yes]: ", "yes") | |||
There was a problem hiding this comment.
I now get this message when I have 4 VMs selected for MicroCloud, and when I confirm all 4 of them are displayed, so apparently they are all eligible?
There was a problem hiding this comment.
Hm, yeah it seems my approach was a bit naive. Should have a fix for that soon.
@ru-fu This indicates that there are more items in the table than can be shown at once (which is max 15). You should be able to press the down arrow key to move down the table. The If for some reason that showed up for you without 16 items in the table, it might be some weird formatting edge case. If it happens again, could you copy the table for me please? |
I only have 7 disks set up, and the table had only the 3 that were left for distributed storage. |
Changes the requirement for ceph to at least 1 disk per machine up to 3 machines, rather than at least 1 disk for every machine.
Additionally, adds prompts to the interactive init to confirm if users wish to continue setting up ceph or ovn if some systems don't meet the requirements and must be skipped.