Tutorial updates #285
Merged
Tutorial updates #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ru-fu
requested review from
tomponline,
masnax,
roosterfish and
markylaing
as code owners
roosterfish
previously approved these changes
Apr 16, 2024
There was a problem hiding this comment.
LGTM!
I was wondering if it would be helpful to also add the lxc shell micro01 and lxc config trust example commands in the info box after the lxc file push to make it clear where it has to be executed but I guess this would be duplicated information then in both the UI instructions and in the docs. Just a thought should not be a blocker.
Explain how to transfer the certificate to one of the cluster members. Signed-off-by: Ruth Fuchss <[email protected]>
We now have a section that sends readers to the LXD docs after the tutorial. The sentence at the beginning is confusing. Signed-off-by: Ruth Fuchss <[email protected]>
|
Good point - updated. :) |
roosterfish
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.