Only restart LXD if version is less than 5.21 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masnax
requested review from
tomponline,
roosterfish and
markylaing
as code owners
masnax
changed the title
tomponline
reviewed
Apr 18, 2024
tomponline
requested changes
Apr 19, 2024
… that of 5.21 Signed-off-by: Max Asnaashari <[email protected]>
tomponline
approved these changes
Apr 19, 2024
|
The test failures are addressed by #289 |
|
@masnax please can you rebase to get the tests passing. Ta |
simondeziel
added a commit
to simondeziel/microcloud
that referenced
this pull request
Apr 24, 2024
canonical#286 Signed-off-by: Simon Deziel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the content interfaces in places in LXD to detect MicroOVN and MicroCeph, we don't need to restart LXD to pick them up anymore.
However, if we don't restart, this breaks support for versions of LXD prior to 5.21 when the content interface was introduced. We can't directly fetch the snap version or the available interfaces of LXD due to the snap confinement, so the best I came up with was to hard-code
5.21into MicroCloud, and compare it to the server version reported from/1.0in LXD.If LXD is not at least version 5.21, then we need to restart the LXD daemon to pick up MicroOVN and MicroCeph integration. Otherwise we can just expect it to be there.