Add helper for setting up MicroCloud proxy #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masnax
requested review from
tomponline,
roosterfish and
markylaing
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
masnax
force-pushed
the
auth-proxy-func
branch
2 times, most recently
from
5e35c6b
to
e5c9ac1
Compare
|
@roosterfish @markylaing This one is now ready for review, thanks. |
|
Ah crap, the microcluster changes clash with MicroCeph. I guess this is blocked on MicroCeph updating to the latest microcluster. |
markylaing
previously requested changes
May 31, 2024
roosterfish
reviewed
Jun 17, 2024
This applies a proxy to a microcluster client for a different service, which instead sends the request to be handled by the MicroCloud daemon, which then forwards it to the unix socket of the corresponding service. If a secret is given, it sets `InsecureSkipVerify` so that we can skip TLS in favour of the pre-cluster-formation auth secret in the request header. Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after #259
In response to reviews from #259, I've added some additional commits to update the microcluster dependency, fix contexts, and add 2 new helpers:
UseAuthProxywhich applies the auth proxy used to manage the API of other services to a microclusterClient. This is now used in place of manually applying the proxy all over the place.AuthProxywhich returns the actual proxy implementation, so we can also reduce the duplication for LXD's client which is not the same structure asmicrocluster's.