Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug system tests #288

Closed
wants to merge 55 commits into from
Closed

Debug system tests #288

wants to merge 55 commits into from

Commits on Apr 18, 2024

  1. test/includes/microcloud: allow using a dedicated storage source device 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f3fcf41 View commit details
    Browse the repository at this point in the history

  2. test/includes/microcloud: only install zfsutils-linux and htop if CLO… 

    …UD_INSPECT is set

Also, stop trying to install snapd and curl as they are included in `ubuntu-minimal:` images.

Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    460a715 View commit details
    Browse the repository at this point in the history

  3. test/includes/microcloud: stop adding ubuntu-minimal: 

    All LXD releases we care about have that remote builtin now.

Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    894df61 View commit details
    Browse the repository at this point in the history

  4. test/includes/check: require instance_ready_state API on host LXD 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a3db46f View commit details
    Browse the repository at this point in the history

  5. test/suites/basic: use ubuntu-minimal for c1/v1 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    29d4fd4 View commit details
    Browse the repository at this point in the history

  6. test/suites/basic: poll less frequently when waiting on c1/v1 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5782411 View commit details
    Browse the repository at this point in the history

  7. test/suites/basic: report when c1/v1 have booted successfully 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    6703cab View commit details
    Browse the repository at this point in the history

  8. test/main: fix indentation 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    84af383 View commit details
    Browse the repository at this point in the history

  9. github: fix check for compat with Go 1.22.0 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d9c0bb7 View commit details
    Browse the repository at this point in the history

  10. github: align tests job with LXD's 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    63aef4e View commit details
    Browse the repository at this point in the history

  11. github: add initial (snap-based) system tests 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    65027ba View commit details
    Browse the repository at this point in the history

  12. github: require system tests to pass before triggering LP build 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e37f1cb View commit details
    Browse the repository at this point in the history

  13. test/includes/microcloud: nicer output when wiping/deleting disks 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    312586a View commit details
    Browse the repository at this point in the history

  14. test/suite/basic: nicer output when starting c1/v1 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    1685e7d View commit details
    Browse the repository at this point in the history

  15. test/includes/microcloud: use lxd default channel (5.21/stable as of … 

    …today)

Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a4e80b0 View commit details
    Browse the repository at this point in the history

  16. test/includes/microcloud: fix restore_system arg passing 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8a82f7b View commit details
    Browse the repository at this point in the history

  17. test/suites/basic: create smaller c1/v1 instances 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    841546a View commit details
    Browse the repository at this point in the history

  18. test/suites/basic: rename test_instances to test_instances_launch 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    05d2021 View commit details
    Browse the repository at this point in the history

  19. test/main: rename test_instances to test_instances_launch 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    6647c2f View commit details
    Browse the repository at this point in the history

  20. test/includes/microcloud: set suitable PATH in the profile 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    6044ed4 View commit details
    Browse the repository at this point in the history

  21. test/includes/microcloud: call new_system() in new_systems() 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c26b1e6 View commit details
    Browse the repository at this point in the history

  22. test/includes/microcloud: use wait even if CONCURRENT_SETUP!=1 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    1fc2abc View commit details
    Browse the repository at this point in the history

  23. test/suites/basic: use less subshells in test_instances_launch() 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    210ba10 View commit details
    Browse the repository at this point in the history

  24. test/suites/basic: add test_instances_config() test 

    This test verifies storage pool and network default selection based on
available ones.

Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    cc1f5f6 View commit details
    Browse the repository at this point in the history

  25. test/suites/preseed: use less subshells 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    28f140d View commit details
    Browse the repository at this point in the history

  26. test/main: add test_instances_config 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a21f3a6 View commit details
    Browse the repository at this point in the history

  27. test/suites/basic: optionally skip launching VMs on microcloud 

    On GHA runners, the microcloud hosts are VMs so we are already 2 VM levels
deep. If a VM is started on top of that, we get pathologically slow VM boot. In
previous tests, the final VM stage didn't even get its LXD agent to dial in
inside of 2 hours.

Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    552cc7d View commit details
    Browse the repository at this point in the history

  28. github: skip launching VMs on top of microcloud VMs 

    On GHA runners, the microcloud hosts are VMs so we are already 2 VM levels
deep. If a VM is started on top of that, we get pathologically slow VM boot. In
previous tests, the final VM stage didn't even get its LXD agent to dial in
inside of 2 hours.

Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    603022d View commit details
    Browse the repository at this point in the history

  29. test/suites/basic: fix TEST_CONSOLE=0 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5718473 View commit details
    Browse the repository at this point in the history

  30. test/suites/preseed: fix TEST_CONSOLE=0 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    51bb646 View commit details
    Browse the repository at this point in the history

  31. test/suites/add: reduce subshell use 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5913911 View commit details
    Browse the repository at this point in the history

  32. test/includes/microcloud: safer grep 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    bb2da36 View commit details
    Browse the repository at this point in the history

  33. test/suites/add: less subshells 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    b357b8d View commit details
    Browse the repository at this point in the history

  34. test/suites/basic: safer grep 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8bf8980 View commit details
    Browse the repository at this point in the history

  35. test/suites/basic: less subshells 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    05237c6 View commit details
    Browse the repository at this point in the history

  36. test/main: running single test case also require the new_systems call 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    05edfae View commit details
    Browse the repository at this point in the history

  37. test/suites/basic: s/test_case/_test_case/ as it's not an actual test… 

    …ing function

Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    acb3363 View commit details
    Browse the repository at this point in the history

  38. test/main: rework how individual/group test(s) are run 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ea238de View commit details
    Browse the repository at this point in the history

  39. github: split system tests into suites 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4bc8ba5 View commit details
    Browse the repository at this point in the history

  40. test/includes/microcloud: only take a snapshot if SNAPSHOT_RESTORE=1 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f488f18 View commit details
    Browse the repository at this point in the history

  41. test/includes/microcloud: use cohorts for micro{ceph,ovn,cloud} too 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2d2333d View commit details
    Browse the repository at this point in the history

  42. test/includes/microcloud: workaround for LXD shutdown bug (debug) 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    1655238 View commit details
    Browse the repository at this point in the history

  43. test/includes/microcloud: add some echos to set_debug_binaries() 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    867fd0a View commit details
    Browse the repository at this point in the history

  44. test/includes/microcloud: poll less aggressively in lxd_wait_vm() 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4badb3f View commit details
    Browse the repository at this point in the history

  45. test/includes/microcloud: less subshells 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    faf9cf1 View commit details
    Browse the repository at this point in the history

  46. test/includes/microcloud: use LXD latest/edge (canonical/lxd-pkg-snap… 

    …#426)

Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f6cd47a View commit details
    Browse the repository at this point in the history

  47. test/includes/microcloud: safer grep 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a4d84df View commit details
    Browse the repository at this point in the history

  48. test/includes/microcloud: safer grep for matching numeric args 

    We don't want to match on any digit present anywhere like that:

```
$ echo "disk2" | grep -P '\d+'
2
```

Instead, require the searched string to be made of digits only.

Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d4cd4c3 View commit details
    Browse the repository at this point in the history

  49. test/includes/microcloud: use quiet file pushes 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c72c720 View commit details
    Browse the repository at this point in the history

  50. github: sideload microcloud{,d} binaries for system-tests 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a74a6d9 View commit details
    Browse the repository at this point in the history

  51. test/suites/basic: add test OVN connectivity 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    78f92bc View commit details
    Browse the repository at this point in the history

  52. test/suites/basic: use smaller rootfs 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c1eef92 View commit details
    Browse the repository at this point in the history

  53. test/includes/microcloud: simplify rm -rf globbing 

    Signed-off-by: Simon Deziel <[email protected]>
    @simondeziel
    simondeziel committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a827156 View commit details
    Browse the repository at this point in the history

  54. microcloud/test: Only run mismatch 

    Signed-off-by: Max Asnaashari <[email protected]>
    @masnax
    masnax committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a565f16 View commit details
    Browse the repository at this point in the history

  55. microcloud/test/suites: Run interactive first 

    Signed-off-by: Max Asnaashari <[email protected]>
    @masnax
    masnax committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    3067243 View commit details
    Browse the repository at this point in the history