Fix hardcoded uplink #299
Merged
Fix hardcoded uplink #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MggMuggins
requested review from
tomponline,
masnax,
roosterfish and
markylaing
as code owners
MggMuggins
force-pushed
the
fix-hardcoded-uplink
branch
from
1a7310a
to
a261005
Compare
|
@MggMuggins Heads up that this needs a rebase now. |
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
MggMuggins
force-pushed
the
fix-hardcoded-uplink
branch
from
a261005
to
e65a7bc
Compare
|
Woops; forgot about this one. Done. Test failure feels very unlikely to be related. |
masnax
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #277
It feels a little silly to do a bunch of relatively more complex stuff at runtime to fix something that can be fixed by a single source of truth at compile time.