Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service add and service list #355

Merged
merged 8 commits into from
Jul 26, 2024
Merged

Conversation

masnax
Copy link
Contributor

@masnax masnax commented Jul 23, 2024

Closed the old PR to start fresh.

Adds two new commands:

  • microcloud service list will list the cluster members for every installed service, or report if it is not initialized. This will effectively be the same as calling all of the following in succession:
lxc cluster list
microcloud cluster list
microceph cluster list
microovn cluster list

The information shown will be the name, address, dqlite role, and current status of each member.

  • microcloud service add will try to setup MicroOVN and MicroCeph on all existing MicroCloud cluster members, optionally setting up storage and networks for LXD. This is useful if MicroOVN or MicroCeph was at one point not installed on the systems and skipped during microcloud init. LXD and MicroCloud itself are required to already be set up.
    Thanks to Reuse existing MicroCeph and MicroOVN clusters #259 we can also try to re-use a service that partially covers existing MicroCloud cluster members. So if a MicroCloud is set up without MicroCeph, and then the user manually configures MicroCeph to partially cover the cluster, the user can then use microcloud service add to further configure MicroCeph to work with MicroCloud, and set up storage pools for LXD.

@masnax masnax force-pushed the add-list-service branch 2 times, most recently from 1d3252d to 3d83c7b Compare July 24, 2024 03:10
Copy link
Contributor

@roosterfish roosterfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looking very good, only a few smaller comments.

service/lxd.go Show resolved Hide resolved
cmd/microcloud/main_init.go Show resolved Hide resolved
cmd/microcloud/main_init.go Show resolved Hide resolved
cmd/microcloud/services.go Outdated Show resolved Hide resolved
cmd/microcloud/services.go Outdated Show resolved Hide resolved
cmd/microcloud/services.go Show resolved Hide resolved
test/suites/basic.sh Outdated Show resolved Hide resolved
@masnax masnax requested a review from roosterfish July 25, 2024 01:03
@masnax masnax force-pushed the add-list-service branch 3 times, most recently from 3c1bfbc to 2166c48 Compare July 25, 2024 15:19
@masnax masnax force-pushed the add-list-service branch 2 times, most recently from c2f1e86 to 6d35e1c Compare July 25, 2024 15:31
@masnax masnax merged commit a9f70aa into canonical:main Jul 26, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants