CLI: Remove redundant flags #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --wipe, --encrypt and --address flags made sense together with --auto. As the --auto option got removed those flags have to be removed too. Signed-off-by: Julian Pelizäus <[email protected]>
The --wipe flag made sense together with --auto. As the --auto option got removed this flag has to be removed too. Signed-off-by: Julian Pelizäus <[email protected]>
masnax
requested changes
Oct 22, 2024
Comment on lines
-160
to
-161
| wipeAllDisks: c.flagWipeAllDisks, | ||
| encryptAllDisks: c.flagEncryptAllDisks, |
There was a problem hiding this comment.
These fields are no longer assigned on the struct, so I think we can remove them.
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
masnax
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst the
--autofeatures was present having--address,--wipeand--encryptmade sense to influence what is happening in the auto mode.Now after the auto mode is gone those flags have to be removed too.
This is a leftover.
Automating those settings can be done by using the preseed support.