Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add new MicroCloud logos in the reference page #460

Merged
merged 1 commit into from
Nov 8, 2024
Merged

doc: Add new MicroCloud logos in the reference page #460

merged 1 commit into from
Nov 8, 2024

Conversation

gabrielmougard
Copy link
Contributor

@gabrielmougard gabrielmougard self-assigned this Nov 4, 2024
minaelee
minaelee previously approved these changes Nov 5, 2024
View reviewed changes
@roosterfish
Copy link
Contributor

When viewing the docs, should we rather get rid of the logo here entirely? See

Screenshot from 2024-11-06 12-22-37

@minaelee
Copy link
Contributor

minaelee commented Nov 6, 2024 •
edited
Loading

When viewing the docs, should we rather get rid of the logo here entirely? See

I agree.

@gabrielmougard
Copy link
Contributor Author

yes I agree too

@gabrielmougard
Copy link
Contributor Author

@roosterfish @minaelee updated. Could we keep the logos in the images/ directory though? I have an other PR that will use them.

@roosterfish
Copy link
Contributor

roosterfish commented Nov 6, 2024 •
edited
Loading

Thanks for removing it!

Could we keep the logos in the images/ directory though?

Are you referring to #461?
The logo with the text feels a bit too "noisy" in my opinion. Can we maybe just use the square logo as in https://snapcraft.io/microcloud? I have the feeling this would come out more nicely than the one with the text in it.

But in general having all the logos under images/ sounds like a good idea.

@roosterfish roosterfish mentioned this pull request Nov 6, 2024
Merged
@roosterfish
Copy link
Contributor

@gabrielmougard are the images required in this PR? I think they should rather be added in #461.

@gabrielmougard
Copy link
Contributor Author

@roosterfish updated

@roosterfish roosterfish merged commit 92cebfa into canonical:main Nov 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roosterfish roosterfish roosterfish approved these changes

@minaelee minaelee minaelee left review comments

Assignees

@gabrielmougard gabrielmougard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielmougard @roosterfish @minaelee