Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Fix database cache update #485

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hamistao
Copy link
Contributor

@hamistao hamistao commented Nov 13, 2024

A github cache can not be updated using the same key, so instead we update using a different key each time but use the same key to restore it.

Waiting until #474 is merged to rebase

A github cache can not be updated using the same key, so instead we update using a different key each time but use the same key to restore it.

Signed-off-by: hamistao <[email protected]>
@hamistao hamistao marked this pull request as ready for review November 13, 2024 04:59
@hamistao hamistao marked this pull request as draft November 13, 2024 05:01
@hamistao hamistao changed the title Fix database cache update github: Fix database cache update Nov 13, 2024
@roosterfish
Copy link
Contributor

Can be rebased now.

with:
path: /home/runner/vuln-cache
key: trivy-latest-cache
key: trivy-cache-${{ github.run_id }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the default lifetime of those caches? Should we set it to e.g. one week so that GitHub can safely delete them afterwards?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants