Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/gateway storage endpoint - support for private endpoints for Azure and AWS #29

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Feature/gateway storage endpoint - support for private endpoints for Azure and AWS #29

merged 3 commits into from
Feb 8, 2022

Conversation

Barteus
Copy link
Contributor

@Barteus Barteus commented Feb 4, 2022

Changes:

  • Added gateway storage endpoint to support the private endpoints in Azure and AWS
  • Renamed the gateway fields to keep the same naming convention as access and secret key. ("_" to "-")

Tests:

@Barteus
Added gateway storage endpoint to support the private endpoints in Az…
10c9f5c 
…ure and AWS

Renamed the gateway fields to keep same convention as access and secret key.
@Barteus
Tox tests fixes
195de72
@Barteus Barteus requested a review from a team as a code owner February 4, 2022 10:59
@DomFleischmann DomFleischmann requested a review from a team February 4, 2022 11:50
DomFleischmann
DomFleischmann reviewed Feb 7, 2022
View reviewed changes
Copy link
Contributor

@DomFleischmann DomFleischmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides minor commnet, @ca-scribner can you also take a look?

tests/unit/test_charm.py Show resolved Hide resolved
ca-scribner
ca-scribner approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an azure storage handy to actually test it, but I assume you've already done that.
overall lgtm

I pushed a commit with some changes to readme.md but you can modify as you see fit

@Barteus
Copy link
Contributor Author

Barteus commented Feb 8, 2022

lgtm

@ca-scribner ca-scribner merged commit 9591e68 into canonical:master Feb 8, 2022
@ca-scribner ca-scribner mentioned this pull request Feb 10, 2022
Merged
@Barteus Barteus deleted the feature/gateway-custom-endpoint branch February 13, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DomFleischmann DomFleischmann DomFleischmann left review comments

@ca-scribner ca-scribner ca-scribner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Barteus @DomFleischmann @ca-scribner