tests: remove unnecessary patching of private ops class #330
Conversation
There was a problem hiding this comment.
Thank you so much for this change @tonyandrewmeyer - Really appreciate your foresight here, I notified the DP team + I've made GitHub issues in the other Mongo* repos as to not forget about it
There was a problem hiding this comment.
Hi @tonyandrewmeyer really appreciate your attention here. Thanks for highlighting the new changes in ops and how it will affect the team and the charms!
Left just a question, as some charms' tests do depend on a specific return from a mocked network_get. Can you just explain how should it work from now on?
| @@ -1044,7 +1041,6 @@ def test_set_password_provided(self, connection): | |||
| # verify app data is updated and results are reported to user | |||
| self.assertEqual("canonical123", new_password) | |||
|
|
|||
| @patch_network_get(private_address="1.1.1.1") | |||
There was a problem hiding this comment.
Some of our charms are using this specific value 1.1.1.1 to do further checks, e.g. here.
How can we now mock the network_get and return a specific private_address?
When adding a relation, if there's no global network configured, then Harness checks for one specific to the (relation name, relation ID) and will add 10.0.0.10 if one doesn't exist, and checks for one specific to just the relation name and will add 192.0.2.0 if one doesn't exist. If you need different addresses, then you can just call Harness.add_network, making sure you do this before adding the relation. Calling with just the address (like |
The tests currently patch
ops.testing._TestingModelBackend, which is a private class. This will break in an upcoming release of ops.The patching is actually not required any more, so can just be entirely removed rather than updated.