fix to prevent mongos from forever waiting for creds

canonical · Jan 31, 2024 · 0bc5cf0 · 0bc5cf0
1 parent 12b35da
commit 0bc5cf0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/charms/mongodb/v0/config_server_interface.py b/lib/charms/mongodb/v0/config_server_interface.py
@@ -211,7 +211,6 @@ def _on_relation_changed(self, event) -> None:
             event.relation.id, CONFIG_SERVER_DB_KEY
         )
         if not key_file_contents or not config_server_db:
-            event.defer()
             self.charm.unit.status = WaitingStatus("Waiting for secrets from config-server")
             return
 

diff --git a/tests/integration/sharding_tests/test_sharding_relations.py b/tests/integration/sharding_tests/test_sharding_relations.py
@@ -55,6 +55,7 @@ async def test_build_and_deploy(
         channel="6/edge",
         revision=3,
     )
+
     # TODO: Future PR, once data integrator works with mongos charm deploy that charm instead of
     # packing and deploying the charm in the application dir.
     await ops_test.model.deploy(
@@ -274,7 +275,7 @@ async def test_replication_mongos_relation(ops_test: OpsTest) -> None:
     # clean up relations
     await ops_test.model.applications[REPLICATION_APP_NAME].remove_relation(
         f"{REPLICATION_APP_NAME}:cluster",
-        f"{SHARD_ONE_APP_NAME}:cluster",
+        f"{MONGOS_APP_NAME}:cluster",
     )