Skip to content

Commit

Permalink
Sync libs (#125)
Browse files Browse the repository at this point in the history
* Fix release.yaml (#120)

* Fix release.yaml

Incorrect action was used for uploading charm, resulting in release failure

* Update .github/workflows/release.yaml

Co-authored-by: Jon Seager <[email protected]>

Co-authored-by: Jon Seager <[email protected]>

* remove lib deps (#119)

* remove lib deps

* resolve PR comments

* Housekeeping (#118)

* add template, update years, remove series

* move lib check

* update libs

* ci: update charming-actions

Talking to @taurus-forever about the recently merged change, I noticed that we didn't bump the actual upload action, and also that we weren't actually using the `charming-actions/channel` action.

* ci: fix release.yaml

Release job was depending on a non-existing stage.

* adding necessary features for k8s

Co-authored-by: Jon Seager <[email protected]>
  • Loading branch information
MiaAltieri and jnsgruk authored Oct 25, 2022
1 parent 7c6f00d commit d633e52
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions lib/charms/mongodb/v0/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

# Increment this PATCH version before using `charmcraft publish-lib` or reset
# to 0 if you are raising the major API version
LIBPATCH = 2
LIBPATCH = 3


# path to store mongodb ketFile
Expand All @@ -34,7 +34,7 @@


# noinspection GrazieInspection
def get_create_user_cmd(config: MongoDBConfiguration) -> List[str]:
def get_create_user_cmd(config: MongoDBConfiguration, mongo_path="mongo") -> List[str]:
"""Creates initial admin user for MongoDB.
Initial admin user can be created only through localhost connection.
Expand All @@ -46,7 +46,7 @@ def get_create_user_cmd(config: MongoDBConfiguration) -> List[str]:
this function work correctly
"""
return [
"mongo",
mongo_path,
"mongodb://localhost/admin",
"--quiet",
"--eval",
Expand Down
3 changes: 2 additions & 1 deletion lib/charms/mongodb/v0/mongodb_tls.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

# Increment this PATCH version before using `charmcraft publish-lib` or reset
# to 0 if you are raising the major API version
LIBPATCH = 2
LIBPATCH = 3


logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -247,6 +247,7 @@ def _get_sans(self) -> List[str]:
return [
f"{self.charm.app.name}-{unit_id}",
socket.getfqdn(),
f"{self.charm.app.name}-{unit_id}.{self.charm.app.name}-endpoints",
str(self.charm.model.get_binding(self.peer_relation).network.bind_address),
]

Expand Down

0 comments on commit d633e52

Please sign in to comment.