[DPE-2415] sync libraries and update src as necessary #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
changed the title
MiaAltieri
force-pushed
the
sync-backup-lib
branch
5 times, most recently
from
a37d77c to
959879c
Compare
MiaAltieri
force-pushed
the
sync-backup-lib
branch
from
959879c to
b4fbfce
Compare
MiaAltieri
force-pushed
the
sync-backup-lib
branch
from
455b996 to
51e8557
Compare
MiaAltieri
force-pushed
the
sync-backup-lib
branch
from
02b82bf to
64133ff
Compare
MiaAltieri
changed the title
MiaAltieri
force-pushed
the
sync-backup-lib
branch
from
c33e369 to
27075ff
Compare
dmitry-ratushnyy
previously approved these changes
Sep 5, 2023
delgod
previously approved these changes
Sep 5, 2023
MiaAltieri
dismissed stale reviews from delgod and dmitry-ratushnyy
via
7867b45
MiaAltieri
force-pushed
the
sync-backup-lib
branch
from
27075ff to
7867b45
Compare
MiaAltieri
force-pushed
the
sync-backup-lib
branch
from
7867b45 to
ff88849
Compare
delgod
approved these changes
Sep 6, 2023
dmitry-ratushnyy
approved these changes
Sep 6, 2023
MiaAltieri
added a commit
that referenced
this pull request
Sep 6, 2023
## Issue After #240 where we update the backup libraries we need to update the units tests ## Solution Add unit tests for backup lib, note these were copied from the K8s charm and made to work for the VM charm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After implementing backups on K8s the libraries in each charm are out of sync.
Solution
Update the library code and update the charm to support these new changes
Other changes
Testing versions and requirements updates to solve depency issues in tests
Future PRs
The backup library has had substantial changes and so the old test suite is no longer supported. In a future PR these will be added.
Failing TLS tests are resolved in #242
do NOT review these files
lib/charms/mongodb/v0/helpers.py- copy and paste from k8s charmlib/charms/mongodb/v0/mongodb_backups.py- copy and paste from VM charmtests/unit/test_mongodb_backups.py- removed as is now out of date, will be rewritten in a follow up PR