[DPE-2633] Update data platform libs to use juju secrets for charm external secrets #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-ratushnyy
changed the title
dmitry-ratushnyy
changed the title
...on_tests/new_relations/application-charm/lib/charms/data_platform_libs/v0/data_interfaces.py
Outdated
Show resolved
Hide resolved
..._tests/new_relations/application-charm/lib/charms/data_platform_libs/v0/database_requires.py
Outdated
Show resolved
Hide resolved
dmitry-ratushnyy
force-pushed
the
updated_data_platform_libs
branch
from
1421721 to
9322887
Compare
dmitry-ratushnyy
force-pushed
the
updated_data_platform_libs
branch
3 times, most recently
from
296dd3a to
d24c7f4
Compare
dmitry-ratushnyy
requested review from
MiaAltieri and
delgod
and removed request for
MiaAltieri
MiaAltieri
reviewed
Oct 13, 2023
dmitry-ratushnyy
force-pushed
the
updated_data_platform_libs
branch
from
18a9008 to
932c7f6
Compare
delgod
previously approved these changes
Oct 13, 2023
No, I don't think so. The only changes I made in the mongodb_provides were because how we were getting passwords. The rest should work "out of box" |
MiaAltieri
previously approved these changes
Oct 13, 2023
juditnovak
reviewed
Oct 13, 2023
juju secrets for charm external secrets
This is a temporary change and will be removed once we will switch to different linter
…ard (#246) This PR enables the user to pass the following config options: `replication`(default), `shard`, and `config-server`. This PR supports this options by starting the charm as a `shard` or a `config-server`. If the config option `config-server` is provided, then the charm starts an internal `mongos` service that runs on 0.0.0.0 and is configured to the provided config server. As a POC there are not tests included in this PR. Testing was performed by hand with: ``` charmcraft pack juju deploy ./*charm --config role="shard" shard-one juju deploy ./*charm --config role="config-server" config-server watch -n1 --color juju status --color juju ssh shard-one/0 systemctl status snap.charmed-mongodb.mongod.service exit juju ssh config-server/0 systemctl status snap.charmed-mongodb.mongod.service systemctl status snap.charmed-mongodb.mongos.service exit ``` New snap revison packages a new version of the PBM tool which updated how errors were handled when querying PBM status, commit [4bf9d5f](4bf9d5f) reflects these necessary changes Follow up PR is to be made immediately after merging of this feature is completed and is a requirement of finishing [DPE-2561](https://warthogs.atlassian.net/browse/DPE-2561). For this PR this will be starting `mongos` with a `--auth` and the same `--keyFile` used to start the`mongod` service Future PR is to be started after the follow up PR has been made. Once `mongos` is started with auth [DPE-2562](https://warthogs.atlassian.net/browse/DPE-2562) will be started. This includes creating a basic shared library between `config-server` and `shard` components. In this PR we will: - implement keyfile sharing across shard and config server components - implement adding shards to cluster (Shard removal is saved for later.) As a POC this PR doesn't include handling edge cases, intelligent status reporting, unit tests, or integration tests. These will be handled later on down the line. Specifically: 1. block config change events for changing role of charm 2. report status of internal `mongos` in `update_status` 3. unit tests and integration tests [DPE-2561]: https://warthogs.atlassian.net/browse/DPE-2561?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Pedro Guimaraes <[email protected]>
dmitry-ratushnyy
dismissed stale reviews from MiaAltieri and delgod
via
64a3e57
dmitry-ratushnyy
force-pushed
the
updated_data_platform_libs
branch
from
932c7f6 to
64a3e57
Compare
MiaAltieri
reviewed
Oct 17, 2023
delgod
approved these changes
Oct 17, 2023
MiaAltieri
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The charm must support external secrets to keep sensitive relation data
Solution
To support external secrets we need to import a new version of data platform libs and fix any issues it can cause