-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-2648] POC Remove shards #262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
commented
Oct 6, 2023
MiaAltieri
commented
Oct 6, 2023
MiaAltieri
commented
Oct 6, 2023
MiaAltieri
commented
Oct 6, 2023
delgod
requested changes
Oct 6, 2023
delgod
approved these changes
Oct 6, 2023
dmitry-ratushnyy
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Shard removal not implemented
Solution
Remove shards
Context
When tested by hand, it appears that it takes several calls of
removeShard
for the shard to be properly removed.Limitations
This PR is limited by the behaviour that remote (and local) applications exhibit when scaling down. Specifically if two applications
A
andB
are related and one of these applications scale down bothA
andB
will receiverelation-broken
andrelation-departed
events. This can lead to some unwanted behaviour. (Which is shown in the consistently failingrelation
tests).The workaround for this will require more research and potentially a new library for the code needed to fix this situation and will be done in the next PR.
See bug filed by DPE team regarding this
See ongoing conversation to find a clean solution
Testing
As this PR is a POC testing was done by hand: