[DPE-2731] Secret labels (6/edge) #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juditnovak
force-pushed
the
DPE-2731_secret_labels_6edge
branch
from
f5ddc6a to
26e9f15
Compare
juditnovak
force-pushed
the
DPE-2731_secret_labels_6edge
branch
2 times, most recently
from
c3f0ebd to
4e47668
Compare
dmitry-ratushnyy
previously approved these changes
Oct 13, 2023
|
Hi Judit, great observation on libs here. We already have an open PR fixing this, hopefully we can get this merged asap it doesnt block your changes |
MiaAltieri
previously approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Thank you for your work here! Ideally we can wait until #271 is merged so those nasty lib issues go away
juditnovak
dismissed stale reviews from MiaAltieri and dmitry-ratushnyy
via
6cb2efa
juditnovak
force-pushed
the
DPE-2731_secret_labels_6edge
branch
4 times, most recently
from
6cbcfcc to
0e99018
Compare
dmitry-ratushnyy
previously approved these changes
Oct 16, 2023
delgod
previously approved these changes
Oct 16, 2023
MiaAltieri
previously approved these changes
Oct 16, 2023
juditnovak
dismissed stale reviews from MiaAltieri, delgod, and dmitry-ratushnyy
via
0824ee7
juditnovak
force-pushed
the
DPE-2731_secret_labels_6edge
branch
from
bc6d9bb to
0824ee7
Compare
juditnovak
force-pushed
the
DPE-2731_secret_labels_6edge
branch
from
0824ee7 to
5e79252
Compare
dmitry-ratushnyy
approved these changes
Oct 17, 2023
delgod
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details on original PR: #268
NOTE:
I've moved the LIBVERSION numbers to correspond to the
v0directory where those libs reside -- as CI couldn't run otherwise.To be rebased after #271 is merged -- until then downgrading
LIBVERSIONto have pipelines runnig