[DPE-2700] Move primary on shard removal #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
commented
Oct 16, 2023
MiaAltieri
force-pushed
the
move_primary
branch
from
7d0196b to
28160e1
Compare
MiaAltieri
force-pushed
the
move_primary
branch
from
599b59c to
7837e28
Compare
MiaAltieri
commented
Oct 16, 2023
delgod
requested changes
Oct 17, 2023
dmitry-ratushnyy
previously approved these changes
Oct 17, 2023
delgod
previously approved these changes
Oct 18, 2023
MiaAltieri
force-pushed
the
move_primary
branch
from
09b5a0c to
37d78d3
Compare
dmitry-ratushnyy
approved these changes
Oct 19, 2023
delgod
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Code currently blocks the removal of primary
Solution
permit removal of shard and movePrimary on database that use that shard as a primary shard