-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-2763] POC Status reporting shard side #275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
force-pushed
the
status-reporting-shard-side
branch
from
October 19, 2023 09:51
6d5bb95
to
fd56c7b
Compare
MiaAltieri
changed the title
[DPE-2763] Status reporting shard side
[DPE-2763] POC Status reporting shard side
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Mia! just a few points / questions to clarify
MiaAltieri
force-pushed
the
status-reporting-shard-side
branch
from
October 27, 2023 08:41
3b193ed
to
b3b8417
Compare
Mehdi-Bendriss
previously approved these changes
Oct 27, 2023
MiaAltieri
force-pushed
the
status-reporting-shard-side
branch
from
October 27, 2023 09:09
b3b8417
to
bb09d2a
Compare
dmitry-ratushnyy
previously approved these changes
Oct 27, 2023
Mehdi-Bendriss
previously approved these changes
Oct 27, 2023
MiaAltieri
dismissed stale reviews from Mehdi-Bendriss and dmitry-ratushnyy
via
October 27, 2023 11:43
3eb8b72
dmitry-ratushnyy
approved these changes
Oct 27, 2023
Mehdi-Bendriss
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Statuses are not properly reported for shards in update status hook
Solution
Report statuses
Testing