Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scale down check for sharding #310

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix scale down check for sharding #310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87614d8
fix scale down
MiaAltieri Nov 28, 2023
a5465e4
Merge branch '6/edge' into fix-scale-down
MiaAltieri Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/charm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1317,9 +1317,9 @@ def check_relation_broken_or_scale_down(self, event: RelationDepartedEvent) -> N
Relation departed and relation broken events occur during scaling down or during relation
removal, only relation departed events have access to metadata to determine which case.
"""
self.set_scaling_down(event)
scaling_down = self.set_scaling_down(event)

if self.is_scaling_down(event.relation.id):
if scaling_down:
logger.info(
"Scaling down the application, no need to process removed relation in broken hook."
)
Expand All @@ -1334,12 +1334,14 @@ def has_departed_run(self, rel_id: int) -> bool:
rel_departed_key = self._generate_relation_departed_key(rel_id)
return rel_departed_key in self.unit_peer_data

def set_scaling_down(self, event: RelationDepartedEvent) -> None:
def set_scaling_down(self, event: RelationDepartedEvent) -> bool:
"""Sets whether or not the current unit is scaling down."""
# check if relation departed is due to current unit being removed. (i.e. scaling down the
# application.)
rel_departed_key = self._generate_relation_departed_key(event.relation.id)
self.unit_peer_data[rel_departed_key] = json.dumps(event.departing_unit == self.unit)
scaling_down = json.dumps(event.departing_unit == self.unit)
self.unit_peer_data[rel_departed_key] = scaling_down
return scaling_down

@staticmethod
def _generate_relation_departed_key(rel_id: int) -> str:
Expand Down