Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-3216] Bump workflow version for CI to version 8 #321

Merged
merged 4 commits into from
Jan 3, 2024
Merged

[DPE-3216] Bump workflow version for CI to version 8 #321

merged 4 commits into from
Jan 3, 2024

Conversation

dmitry-ratushnyy
Copy link
Contributor

@dmitry-ratushnyy dmitry-ratushnyy commented Jan 3, 2024 •
edited
Loading

Issue

We need to keep our github workflows up-to date with data platform ones

Solution

Update the workflows to latest version

Related issue

https://warthogs.atlassian.net/browse/DPE-3216

@dmitry-ratushnyy dmitry-ratushnyy force-pushed the bump_workflow_version_for_ci branch from 313b1a6 to 7a009c4 Compare January 3, 2024 09:28
carlcsaposs-canonical
carlcsaposs-canonical reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all dpw versions:

mongodb-operator/tox.ini

Line 81 in 7a009c4

git+https://github.com/canonical/[email protected]\#subdirectory=python/pytest_plugins/pytest_operator_cache

@phvalguima phvalguima self-requested a review January 3, 2024 10:30
carlcsaposs-canonical
carlcsaposs-canonical reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one missing:

mongodb-operator/.github/workflows/sync_issue_to_jira.yaml

Line 12 in 97cd14e

uses: canonical/data-platform-workflows/.github/workflows/sync_issue_to_jira.yaml@v2

other than that, looks good

@dmitry-ratushnyy dmitry-ratushnyy changed the title Bump workflow version for CI to version 8 [DPE-3105] Bump workflow version for CI to version 8 Jan 3, 2024
@dmitry-ratushnyy dmitry-ratushnyy changed the title [DPE-3105] Bump workflow version for CI to version 8 [DPE-3216] Bump workflow version for CI to version 8 Jan 3, 2024
@dmitry-ratushnyy dmitry-ratushnyy merged commit b425bc5 into 6/edge Jan 3, 2024
@dmitry-ratushnyy dmitry-ratushnyy deleted the bump_workflow_version_for_ci branch January 3, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phvalguima phvalguima phvalguima approved these changes

@MiaAltieri MiaAltieri MiaAltieri approved these changes

@Mehdi-Bendriss Mehdi-Bendriss Mehdi-Bendriss approved these changes

@carlcsaposs-canonical carlcsaposs-canonical carlcsaposs-canonical approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dmitry-ratushnyy @phvalguima @MiaAltieri @Mehdi-Bendriss @carlcsaposs-canonical