Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-3083] Make integration tests work with existing cluster #324

Merged
merged 27 commits into from
Jan 12, 2024
Merged

[DPE-3083] Make integration tests work with existing cluster #324

merged 27 commits into from
Jan 12, 2024

Conversation

dmitry-ratushnyy
Copy link
Contributor

@dmitry-ratushnyy dmitry-ratushnyy commented Jan 4, 2024 •
edited by MiaAltieri
Loading

Issue

It should be possible to run integration tests agains the existing cluster (if provided by a user)

Solution

Update integration tests so they will support existing user clusters

Future PR

Make these changes for sharding tests (if needed) + add these changes to the k8s charm

@dmitry-ratushnyy dmitry-ratushnyy changed the title [WIP] [DPE-3083] [WIP] [DPE-3083] Make integration tests work with existing cluster Jan 8, 2024
@dmitry-ratushnyy dmitry-ratushnyy changed the title [WIP] [DPE-3083] Make integration tests work with existing cluster [DPE-3083] Make integration tests work with existing cluster Jan 10, 2024
Mehdi-Bendriss
Mehdi-Bendriss reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I just have a couple of remarks and should be good to go

tests/integration/backup_tests/test_backups.py Outdated Show resolved Hide resolved
tests/integration/ha_tests/helpers.py Outdated Show resolved Hide resolved
tests/integration/ha_tests/helpers.py Outdated Show resolved Hide resolved
tests/integration/tls_tests/helpers.py Show resolved Hide resolved
@Mehdi-Bendriss Mehdi-Bendriss self-requested a review January 11, 2024 19:02
Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Jan 11, 2024
View reviewed changes
@dmitry-ratushnyy
Copy link
Contributor Author

LGTM

@MiaAltieri MiaAltieri merged commit 233846e into 6/edge Jan 12, 2024
19 checks passed
@MiaAltieri MiaAltieri deleted the DPE-3083 branch January 12, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mehdi-Bendriss Mehdi-Bendriss Mehdi-Bendriss approved these changes

@MiaAltieri MiaAltieri MiaAltieri approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitry-ratushnyy @MiaAltieri @Mehdi-Bendriss