[DPE-3310] New DataPeer(Unit) objects handling Peer Relation Data (so far secrets only) -- Juju 3.1.7 #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
...furthermore you may wanna evaluate if this is your preferred choice, or rather the "dyamic secret creation". (See Peer Realtoin Data Spec ) I can give you more insight to pros and cons. |
MiaAltieri
reviewed
Jul 15, 2024
Comment on lines
+143
to
+147
| additional_secret_fields=[ | ||
| "backup-password", | ||
| "operator-password", | ||
| "monitor-password", | ||
| ], |
There was a problem hiding this comment.
will not need this in the new version. Dynamically introduce the name of the secrets when we set them
MiaAltieri
reviewed
Jul 15, 2024
Comment on lines
+154
to
+160
| additional_secret_fields=[ | ||
| "ca-secret", | ||
| "key-secret", | ||
| "cert-secret", | ||
| "csr-secret", | ||
| "chain-secret", | ||
| ], |
MiaAltieri
reviewed
Jul 15, 2024
|
|
||
| label = None | ||
| if scope == APP_SCOPE: | ||
| self.peer_relation_app.update_relation_data(peers.id, {key: value}) |
There was a problem hiding this comment.
both update_relation_data([...]) with set_secret(peer.id, key,value) - like in postgres charm
Gu1nness
added a commit
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same code as #332, running on Juju 3.1.7