Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-3500] Share backup password + create&list backups #351

Merged
merged 17 commits into from
Feb 20, 2024
Merged

[DPE-3500] Share backup password + create&list backups #351

merged 17 commits into from
Feb 20, 2024

Conversation

MiaAltieri
Copy link
Contributor

Issue

Backups are not feasible in sharded clusters

Solution

Make backups possible in sharded cluster + add tests.

Necessary changes to make backups feasible in sharded cluster:

  1. pbm password shared across cluster
  2. shards restart with new pbm uri

Other Changes

pbm was incorrectly configured to the wrong URI, according to the documentation it should use standalone URI

@MiaAltieri MiaAltieri force-pushed the share-backup-password branch from 123a9b7 to e3c8390 Compare February 19, 2024 10:52
@Mehdi-Bendriss Mehdi-Bendriss self-requested a review February 19, 2024 13:54
Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Feb 19, 2024
View reviewed changes
delgod
delgod previously approved these changes Feb 19, 2024
View reviewed changes
lib/charms/mongodb/v0/mongodb.py Outdated Show resolved Hide resolved
percona-release_latest.generic_all.deb Outdated Show resolved Hide resolved
tests/integration/sharding_tests/test_sharding_backups.py Show resolved Hide resolved
@MiaAltieri MiaAltieri dismissed stale reviews from delgod and Mehdi-Bendriss via 4cdd8ad February 19, 2024 15:23
Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Feb 19, 2024
View reviewed changes
@MiaAltieri MiaAltieri force-pushed the share-backup-password branch from 4cdd8ad to f5b7ce6 Compare February 19, 2024 15:31
@MiaAltieri MiaAltieri merged commit 5b8c969 into 6/edge Feb 20, 2024
32 checks passed
@MiaAltieri MiaAltieri deleted the share-backup-password branch February 20, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delgod delgod delgod approved these changes

@dmitry-ratushnyy dmitry-ratushnyy Awaiting requested review from dmitry-ratushnyy

@Mehdi-Bendriss Mehdi-Bendriss Awaiting requested review from Mehdi-Bendriss

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MiaAltieri @delgod @Mehdi-Bendriss @dmitry-ratushnyy