-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrating to DPE int tests for CI #354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
force-pushed
the
update-ci-int-tests
branch
2 times, most recently
from
February 9, 2024 15:42
24774cf
to
f668bf0
Compare
MiaAltieri
force-pushed
the
update-ci-int-tests
branch
from
February 9, 2024 15:49
f668bf0
to
578d014
Compare
MiaAltieri
force-pushed
the
update-ci-int-tests
branch
from
February 9, 2024 17:26
9c0e4f2
to
7a92163
Compare
MiaAltieri
force-pushed
the
update-ci-int-tests
branch
2 times, most recently
from
February 9, 2024 18:05
46ce79d
to
7b5e9c2
Compare
MiaAltieri
force-pushed
the
update-ci-int-tests
branch
from
February 9, 2024 18:09
7b5e9c2
to
78e7987
Compare
MiaAltieri
force-pushed
the
update-ci-int-tests
branch
from
February 16, 2024 12:05
7a189d6
to
19eb134
Compare
MiaAltieri
force-pushed
the
update-ci-int-tests
branch
from
February 16, 2024 12:10
19eb134
to
3a9b9ab
Compare
MiaAltieri
force-pushed
the
update-ci-int-tests
branch
from
February 16, 2024 13:27
1ed630d
to
3105406
Compare
MiaAltieri
changed the title
WIP migrating to DPE int tests for CI
migrating to DPE int tests for CI
Feb 16, 2024
Mehdi-Bendriss
previously approved these changes
Feb 16, 2024
taurus-forever
previously approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice to see you onboard!
BTW, consider to update contributors guide: https://github.com/canonical/mongodb-operator/blob/6/edge/CONTRIBUTING.md?plain=1#L57-L65 (can be the next PR).
carlcsaposs-canonical
previously approved these changes
Feb 16, 2024
Co-authored-by: Carl Csaposs <[email protected]>
MiaAltieri
dismissed stale reviews from carlcsaposs-canonical, taurus-forever, and Mehdi-Bendriss
via
February 16, 2024 15:15
5cfcedc
taurus-forever
approved these changes
Feb 16, 2024
Mehdi-Bendriss
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We are not using DP workflows for int tests, this causes two problems:
Solution
migrate to the new DP job for int tests