Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating to DPE int tests for CI #354

Merged
merged 19 commits into from
Feb 19, 2024
Merged

migrating to DPE int tests for CI #354

merged 19 commits into from
Feb 19, 2024

Conversation

MiaAltieri
Copy link
Contributor

@MiaAltieri MiaAltieri commented Feb 9, 2024

Issue

We are not using DP workflows for int tests, this causes two problems:

  1. forked PRs fail due to inability to access secrets
  2. we want to easily share secrets across the int tests

Solution

migrate to the new DP job for int tests

@MiaAltieri MiaAltieri force-pushed the update-ci-int-tests branch 2 times, most recently from 24774cf to f668bf0 Compare February 9, 2024 15:42
@MiaAltieri MiaAltieri force-pushed the update-ci-int-tests branch 2 times, most recently from 46ce79d to 7b5e9c2 Compare February 9, 2024 18:05
@MiaAltieri MiaAltieri changed the title WIP migrating to DPE int tests for CI migrating to DPE int tests for CI Feb 16, 2024
Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Feb 16, 2024
taurus-forever
taurus-forever previously approved these changes Feb 16, 2024
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to see you onboard!
BTW, consider to update contributors guide: https://github.com/canonical/mongodb-operator/blob/6/edge/CONTRIBUTING.md?plain=1#L57-L65 (can be the next PR).

.github/workflows/release.yaml Outdated Show resolved Hide resolved
@Mehdi-Bendriss Mehdi-Bendriss self-requested a review February 16, 2024 17:02
@MiaAltieri MiaAltieri merged commit 3016d4d into 6/edge Feb 19, 2024
31 checks passed
@MiaAltieri MiaAltieri deleted the update-ci-int-tests branch February 19, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants