Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-3501] - add restore test for sharded cluster #359

Merged
merged 8 commits into from
Feb 26, 2024

Conversation

MiaAltieri
Copy link
Contributor

@MiaAltieri MiaAltieri commented Feb 21, 2024

Issue

Uncertain that restores are supported in current backup implemenation

Solution

Verify their functionality via an integration test

  1. write some data into a shared collection.
  2. check the amount of data on each shard
  3. make a backup
  4. write more data.
  5. check the amount of data grown on each shard.
  6. stop writing. make a restore
  7. check the amount of data on each shard; should be equal to step 2

@MiaAltieri MiaAltieri force-pushed the cluster-restore-backup branch from 7b6a1b8 to cfa47d8 Compare February 22, 2024 10:22
@MiaAltieri MiaAltieri force-pushed the cluster-restore-backup branch from 61676f9 to e5c21bc Compare February 22, 2024 12:03
@MiaAltieri MiaAltieri changed the title add restore test [DPE-3293] - add restore test for sharded cluster Feb 22, 2024
@MiaAltieri MiaAltieri changed the title [DPE-3293] - add restore test for sharded cluster [DDPE-3501] - add restore test for sharded cluster Feb 22, 2024
phvalguima
phvalguima previously approved these changes Feb 22, 2024
Copy link
Contributor

@phvalguima phvalguima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
After discussing, the missing restore in a new cluster test will be covered as part of DPE-3609

Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mia, it looks good - I have a couple of questions

tests/integration/sharding_tests/test_sharding_backups.py Outdated Show resolved Hide resolved
tests/integration/sharding_tests/test_sharding_backups.py Outdated Show resolved Hide resolved
tests/integration/sharding_tests/test_sharding_backups.py Outdated Show resolved Hide resolved
@MiaAltieri MiaAltieri force-pushed the cluster-restore-backup branch from 11ae420 to c3ef8dd Compare February 23, 2024 17:38
@MiaAltieri MiaAltieri merged commit 327458c into 6/edge Feb 26, 2024
32 checks passed
@MiaAltieri MiaAltieri deleted the cluster-restore-backup branch February 26, 2024 08:10
@delgod delgod changed the title [DDPE-3501] - add restore test for sharded cluster [DPE-3501] - add restore test for sharded cluster Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants