pr feedback

canonical · Feb 23, 2024 · 2db1e06 · 2db1e06
1 parent ba6df17
commit 2db1e06
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/src/charm.py b/src/charm.py
@@ -5,7 +5,6 @@
 import os
 import json
 import pwd
-import subprocess
 from charms.mongodb.v1.helpers import copy_licenses_to_unit, KEY_FILE
 from charms.operator_libs_linux.v1 import snap
 from pathlib import Path
@@ -364,12 +363,7 @@ def _generate_relation_departed_key(rel_id: int) -> str:
 
     def open_mongos_port(self) -> None:
         """Opens the mongos port for TCP connections."""
-        try:
-            logger.debug("opening tcp port")
-            subprocess.check_call(["open-port", "{}/TCP".format(Config.MONGOS_PORT)])
-        except subprocess.CalledProcessError as e:
-            logger.exception("failed opening port: %s", str(e))
-            raise
+        self.unit.open_port("tcp", Config.MONGOS_PORT)
 
     # END: helper functions