pr feedback

canonical · Jan 5, 2024 · a5a1432 · a5a1432
1 parent 72ed4cf
commit a5a1432
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/charms/mongos/v0/mongos_client_interface.py b/lib/charms/mongos/v0/mongos_client_interface.py
@@ -102,7 +102,7 @@ def _on_relation_changed(self, event) -> None:
             if isinstance(new_extra_user_roles, str):
                 new_extra_user_roles = [new_extra_user_roles]
 
-            self.charm.set_user_role(new_extra_user_roles)
+            self.charm.set_user_roles(new_extra_user_roles)
 
 
 class MongosRequirer(Object):
@@ -120,7 +120,7 @@ def __init__(
         self.charm = charm
 
         if not database_name:
-            database_name = f"{self.charm.app}-mongos"
+            database_name = f"{self.charm.app}"
 
         self.database_requires = DatabaseRequires(
             self.charm,

diff --git a/src/charm.py b/src/charm.py
@@ -239,7 +239,7 @@ def share_uri(self) -> None:
         # TODO future PR - generate different URI for data-integrator as that charm will not
         # communicate to mongos via the Unix Domain Socket.
 
-    def set_user_role(self, roles: List[str]) -> None:
+    def set_user_roles(self, roles: List[str]) -> None:
         """Updates the roles for the mongos user."""
         roles_str = ",".join(roles)
         self.app_peer_data[USER_ROLES_TAG] = roles_str

diff --git a/tests/integration/application/lib/charms/mongos/v0/mongos_client_interface.py b/tests/integration/application/lib/charms/mongos/v0/mongos_client_interface.py
@@ -108,7 +108,7 @@ def _on_relation_changed(self, event) -> None:
             if isinstance(new_extra_user_roles, str):
                 new_extra_user_roles = [new_extra_user_roles]
 
-            self.charm.set_user_role(new_extra_user_roles)
+            self.charm.set_user_roles(new_extra_user_roles)
 
 
 class MongosRequirer(Object):
@@ -126,7 +126,7 @@ def __init__(
         self.charm = charm
 
         if not database_name:
-            database_name = f"{self.charm.app}-mongos"
+            database_name = f"{self.charm.app}"
 
         self.database_requires = DatabaseRequires(
             self.charm,