[DPE-3180] Share connection info with host application #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
commented
Jan 5, 2024
| @@ -35,7 +35,7 @@ | |||
|
|
|||
| # Increment this PATCH version before using `charmcraft publish-lib` or reset | |||
| # to 0 if you are raising the major API version | |||
| LIBPATCH = 5 | |||
| LIBPATCH = 2 | |||
There was a problem hiding this comment.
ported file over from mongodb charm
MiaAltieri
commented
Jan 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 6/edge #13 +/- ##
=========================================
Coverage ? 75.63%
=========================================
Files ? 3
Lines ? 238
Branches ? 0
=========================================
Hits ? 180
Misses ? 58
Partials ? 0 ☔ View full report in Codecov by Sentry. |
dmitry-ratushnyy
previously approved these changes
Jan 8, 2024
Mehdi-Bendriss
previously approved these changes
Jan 8, 2024
src/config.py
Outdated
Comment on lines
14
to
16
| MONGOS_SOCKET_URI_FMT = ( | ||
| "%2Fvar%2Fsnap%2Fcharmed-mongodb%2Fcommon%2Fvar%2Fmongodb-27018.sock" | ||
| ) |
There was a problem hiding this comment.
you can simplify this with the following:
from urllib.parse import quote
MONGOS_SOCKET_URI_FMT = quote(MONGOS_SOCKET, safe='')
MiaAltieri
dismissed stale reviews from Mehdi-Bendriss and dmitry-ratushnyy
via
f1e603e
Mehdi-Bendriss
approved these changes
Jan 8, 2024
dmitry-ratushnyy
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
application hosting the subordinate charm
mongosdoes not receive its credentials for communicating with the sharded mongodb deployment